Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport verify_destination from Nautilus - Symlink and freespace fixes #1061

Closed
wants to merge 1 commit into from
Closed

Conversation

rcaridade145
Copy link

Should help with the symlink issues like #315 , #947 , #748 . This version also verifies the amount of freespace available before copy.

Symlink and freespace fixes
@lukefromdc
Copy link
Member

Note that with g_autofree only gcc and clang can build the code (see dunst-project/dunst#522) but I'm not sure we need to worry about this at all, and if this is a backport from GNOME they don't either.

@lukefromdc lukefromdc self-requested a review September 29, 2018 02:51
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and runs fine, not sure how to test the intended use cases of this. Copying a symlink still defaults to making a copy of the symlink, not the contents of the directory it points to. Most importantly, deleting a test symlink deleted the symlink and not the directory pointed to. Needs testing with the issues references but as a GNOME backport this should hopefully work here as in Nautilus.

@lukefromdc lukefromdc requested a review from a team September 29, 2018 02:54
@raveit65
Copy link
Member

How to test?

@rcaridade145
Copy link
Author

@raveit65 The commit I first looked into was https://gitlab.gnome.org/GNOME/nautilus/commit/f83d19ac913964240515338e8858977cf6632157 but ended up porting the latest version of the code. This commit mentions issue #947 but the code is from master. At least #947 ought to be solved by this.

@rcaridade145
Copy link
Author

#748 is already fixed by the last backport on #1058 . Sorry for the confusion with all these backports :/

@raveit65
Copy link
Member

I don't get why origin patch from #947 or https://bugzilla.redhat.com/show_bug.cgi?id=1554084
only edit 3 lines.
And you edit much more code.

@raveit65
Copy link
Member

No answer from author since nealy 1 year, closing this one. We can re-open PR if someone start again to work on it.

@raveit65 raveit65 closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants