Remove warnings about function declaration isn’t a prototype #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuj
requested review from
clefebvre,
cwendling,
flexiondotorg,
lukefromdc,
monsta,
raveit65,
sc0w,
sunweaver,
vkareh,
yetist and
a team
lukefromdc
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Builds and runs fine, as expected. This should build essentially the same code as before but be more maintainable. That's because declaring these as prototypes means we specify the number of argumentd they expect to receive (zero in 7 cases, one in once case) means if future programmers call them with an extra argument the compiler will throw an error and force them to fix their code.
sc0w
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.