-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Caja does not show icons #1563
Conversation
This fixes the issue, but now i can start a desktop file from all places without confirmation as an trusted application, eg. home dir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works , not sure why caja is not interpreting files in directories owned by root as local (as opposed to remote as on a network filesystem.) I don't know much about how this works, but I suspect the right fix for the issue stated would be to distinguish between files in this one directory and anywhere else
The goal of #1468 was to execute the desktop file from the desktop and /usr/share/applications direction without the confirmation dialog. But from all other directions the confirmation dialog whether this is an trusted file or not should be applied. ........as far i understood this PR correctly. |
Thus we achieved only half that goal: files from the desktop are recognized but
not those in /usr/share/applications. I have confirmed this myself
…On 10/9/2021 at 7:32 PM, "raveit65" ***@***.***> wrote:
The goal of #1468 was to
execute the desktop file from the desktop and
/usr/share/applications direction without the confirmation dialog.
But from all other directions the confirmation dialog if this is
an trusted file or not should be applied. ........as far i
understood this PR correctly.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#1563 (comment)-
939350972
|
I have just compiled Caja from fix-caja branch. It fixes the corresponding #1562 . Thanks for fast response! Also I have added the corresponding manual test to our Ubuntu MATE QA manual test for caja - see https://github.com/ubuntu-mate/qa/blob/master/manual-tests/caja.md#launch-of-desktop-file-from-usrshareapplications , to keep an eye on this possible problem in future. |
…ns and asks user for confirmation on launch of desktop-files here
still needs to manually confirm the trusted application 10-10-2021Screen.video10.42.23.AM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
works as expected now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now lets me see icons and run .desktop files from the desktop and from /usr/share/applications while still blocking them from other directories within the user's directory
Fix Caja does not show icons of applications in /usr/share/applications
Fix #1562