Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Caja does not show icons #1563

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix Caja does not show icons #1563

merged 1 commit into from
Oct 11, 2021

Conversation

zhuyaliang
Copy link
Member

Fix Caja does not show icons of applications in /usr/share/applications
Fix #1562

@raveit65
Copy link
Member

raveit65 commented Oct 9, 2021

This fixes the issue, but now i can start a desktop file from all places without confirmation as an trusted application, eg. home dir.
This was the advantage of #1468

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works , not sure why caja is not interpreting files in directories owned by root as local (as opposed to remote as on a network filesystem.) I don't know much about how this works, but I suspect the right fix for the issue stated would be to distinguish between files in this one directory and anywhere else

@raveit65
Copy link
Member

raveit65 commented Oct 9, 2021

The goal of #1468 was to execute the desktop file from the desktop and /usr/share/applications direction without the confirmation dialog. But from all other directions the confirmation dialog whether this is an trusted file or not should be applied. ........as far i understood this PR correctly.

@lukefromdc
Copy link
Member

lukefromdc commented Oct 9, 2021 via email

@N0rbert
Copy link

N0rbert commented Oct 9, 2021

I have just compiled Caja from fix-caja branch. It fixes the corresponding #1562 . Thanks for fast response!
Hope we will merge it to Ubuntu MATE 21.10, @flexiondotorg ⚠️ .

Also I have added the corresponding manual test to our Ubuntu MATE QA manual test for caja - see https://github.com/ubuntu-mate/qa/blob/master/manual-tests/caja.md#launch-of-desktop-file-from-usrshareapplications , to keep an eye on this possible problem in future.

…ns and asks user for confirmation on launch of desktop-files here
@zhuyaliang
Copy link
Member Author

This fixes the issue, but now i can start a desktop file from all places without confirmation as an trusted application, eg. home dir. This was the advantage of #1468

still needs to manually confirm the trusted application

10-10-2021Screen.video10.42.23.AM.mp4

Copy link
Contributor

@rbuj rbuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
works as expected now.

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now lets me see icons and run .desktop files from the desktop and from /usr/share/applications while still blocking them from other directories within the user's directory

@raveit65 raveit65 merged commit 1942f0a into master Oct 11, 2021
@raveit65 raveit65 deleted the fix-caja branch October 11, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants