Emit accessible-name-change signal for icons only when icons are renamed

[joanmarie]

caja_icon_canvas_item_set_property was emitting accessible-name-change
signals whenever the PROP_EDITABLE_TEXT was being set for an icon. This
method is called by caja_icon_container_request_update_all when the icon
view is first loaded. Thus irrelevant events are being emitted (the name
of each icon didn't change, as far as the user is concerned). Furthermore,
this floods assistive technologies any time the user opens a folder with
a large number of files.

Moving the notification out of caja_icon_canvas_item_set_property and
into end_renaming_mode (where ICON_TEXT_CHANGED is also emitted) solves
the problem of floods of irrelevant notifications while still emitting
the signal when the name actually changes.

[lukefromdc]

While I not sure what these signals do, this PR meant the difference between 2,466 and 106 entries in accerciser from object:property-change:accessible-name on opening /usr/bin in Caja-and the difference in whether Pluma became unresponsive when trying to paste them all in to count them.

[alexarnaud]

Thank you @joanmarie for the fix. Do you think we could do the same for the list view?

Best regards,
Alex.

[joanmarie]

@alexarnaud I am not seeing that event spam for the list view. Are you?

[raveit65]

Honestly i don't see any different with or without both PRs in accerciser app.
But i am complete clueless to use this app.
Also, this app produces abrt alams about python3 in fedora 26 and causes a high proc load.
So i stop testing this.
Building works fine and i see no new build warnings.
So, if it works for you.....

[monsta]

Looks like this only affects a11y features, and I don't use them, so browsing and renaming in icon view works as before for me.

[flexiondotorg]

No regressions observed. Patch committed to Debian and patched package upload to Ubuntu 18.04.

[alexarnaud]

Le 21/04/2018 à 14:22, joanmarie a écrit :

@alexarnaud <https://github.com/alexarnaud> I am not seeing that event spam for the list view. Are you?

Not really, I observe such events:

object:state-changed:sensitive(1, 0, 0) source: [menu item | Open] application: [application | caja] object:state-changed:enabled(1, 0, 0) source: [menu item | Open] application: [application | caja] object:property-change:accessible-name(0, 0, Open) source: [menu item | Open] application: [application | caja] object:visible-data-changed(0, 0, 0) source: [menu item | Open] application: [application | caja] object:property-change:accessible-name(0, 0, Open) source: [menu item | Open] application: [application | caja] object:visible-data-changed(0, 0, 0) source: [menu item | Open] application: [application | caja] object:state-changed:visible(1, 0, 0) source: [menu item | Open] application: [application | caja]

FYI, the list view is the most active view on the blind and visual-impaired community because it is represented on list, not on column. What do you observe Joanie on list view? Best regards, Alex.

[joanmarie]

@alexarnaud I am having no delay problems using Orca on the list view. Are you?

[alexarnaud]

@joanmarie How many files do you have in your test folder? Are you testing Caja or Nautilus ?

Best regards,
Alex.

[joanmarie]

@alexarnaud: 10,000 and both caja and nautilus.

[Texou-]

@joanmarie Well here with Caja 1.20 without your patch I test to open a folder with 800 files and dir, and the delay is about 10 seconds before being loaded, with List View. Shorter with Compact view.

Regards,

[alexarnaud]

@joanmarie Should we use the Orca patch to makes it fast or is it already fast for you without the orca patch?

Best regards,
Alex.

[alexarnaud]

@joanmarie I've done a test, on my Debian Sid VM, with latest Orca from master and Caja 1.20 from unstable, I've observed a lag of 5 seconds on a folder of 10 000 files. I'm using a hard drive, not a SSD.

Best regards,
Alex.