Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK+3] Keyboard layout indicator text in the panel is always white [$10] #28

Open
GiedriusS opened this issue Nov 7, 2015 · 27 comments · Fixed by #29
Open

[GTK+3] Keyboard layout indicator text in the panel is always white [$10] #28

GiedriusS opened this issue Nov 7, 2015 · 27 comments · Fixed by #29

Comments

@GiedriusS
Copy link

GiedriusS commented Nov 7, 2015

As seen in this screenshot https://i.imgur.com/VRBC772.jpg the indicator text that shows the current layout is white. And it is always white regardless of the theme being used. This happens only on gtk3 builds. @raveit65 also confirmed this. libmatekbd version:
[*] libmatekbd-1.12.0_1 MATE keyboard library


There is a $10 open bounty on this issue. Add to the bounty at Bountysource.

@monsta monsta changed the title Keyboard layout indicator text in the panel is always white [GTK+3] Keyboard layout indicator text in the panel is always white Nov 7, 2015
@monsta
Copy link
Contributor

monsta commented Nov 7, 2015

Workaround:

gsettings set org.mate.peripherals-keyboard-xkb.indicator foreground-color '0 0 0'

This will set the font to be always black. If you don't plan changing theme to dark this should be ok 😄

@raveit65
Copy link
Member

raveit65 commented Nov 8, 2015

nice finder, in a ideal world it should read theme fg color, but a gsettings key is sufficient :)

@raveit65
Copy link
Member

@raveit65 raveit65 added this to the gtk+-3 milestone Dec 14, 2015
@monsta
Copy link
Contributor

monsta commented Dec 19, 2015

Yes, it might be. I've already seen it before but didn't like the "hack" word... but we can try it since there's no other fix around...

@monsta
Copy link
Contributor

monsta commented Jun 7, 2016

Nice, it's indeed fixed now, thanks @XRevan86 😄
The font has a bit weird rendering (somewhat blurred), but the color is correct for both light and dark themes.

@monsta
Copy link
Contributor

monsta commented Jun 29, 2016

So I saw this fixed in Debian Testing with GTK+ 3.20, but now I see it in Ubuntu MATE 16.10 with GTK+ 3.18... tried Menta, TraditionalGreen and other themes, the font is still white. 😕

@monsta
Copy link
Contributor

monsta commented Jun 30, 2016

@flexiondotorg: can you reproduce this in Ubuntu 16.10?

@monsta
Copy link
Contributor

monsta commented Oct 21, 2016

@flexiondotorg: I see it now in Ubuntu 16.10 - only with Radiant-MATE though. Seems to be fixed in other themes, at least for 3.20.

@oz123
Copy link

oz123 commented Nov 25, 2016

This bug still exists for me in mate-1.16 built on gentoo.

@oz123
Copy link

oz123 commented Nov 25, 2016

As a work around for this annoying issue, I can suggest the following remedy:

edit foreground-color in org->mate->desktop->peripherals->keyboard->indicator.

Change it to 0 0 0.

@monsta
Copy link
Contributor

monsta commented Nov 25, 2016

Which theme do you use?

@oz123
Copy link

oz123 commented Nov 25, 2016

This happened with GTK+3.18 and GTK+3.20, with the following themes:

Menta, TraditionalGreen, TraditionalOK, GreenSubmarine, BlueMenta and Adwaita.

@raveit65
Copy link
Member

This happened with GTK+3.18 and GTK+3.20, with the following themes:

Menta, TraditionalGreen, TraditionalOK, GreenSubmarine, BlueMenta and Adwaita.

Not here in fedora with gtk+-3.20/22, Changing to a theme with another bg color for the panel change the font color like it should.

@monsta
Copy link
Contributor

monsta commented Nov 25, 2016

Using latest mate-themes is the key. Here I have GTK+ 3.18.9, and I use the latest 3.18 themes, and I don't see this issue.

@vkotovv
Copy link

vkotovv commented Apr 24, 2017

Btw, issue is still present in Ubuntu 16.04 LTS, because it uses GTK+ 3.18. Had to use this workaround with `foreground-color'

@monsta
Copy link
Contributor

monsta commented Apr 25, 2017

If you use the default MATE packages in 16.04, then it's GTK+2 build. I'm not sure we'll be able to fix this for GTK+2.

@vkotovv
Copy link

vkotovv commented Apr 26, 2017

No, I'm using mate 1.18 ppa

@monsta
Copy link
Contributor

monsta commented Apr 26, 2017

Ok, then a theme fix is needed.

@raveit65
Copy link
Member

No, I'm using mate 1.18 ppa

And which theme are you using?
I fixed that for Mate-Radiant theme flexiondotorg/ubuntu-mate-themes@61217fe
If you use another theme you need to add something like this

/* needed for keyboard layout indicator applet */
.mate-panel-menu-bar {
    color: @theme_fg_color;
}

Note, .mate-panel-menu-bar is the main style class for the panel.

@vkotovv
Copy link

vkotovv commented Apr 26, 2017

I use Radiance (as it stated through Appearance Preferences), I guess Mate-Radiant is the other name for that. How can I make use of your fix @raveit65 ?

@raveit65
Copy link
Member

No, Mate-Radiant is based on Radiance but adjusted for Mate.
Create ~.config/gtk-3.0/gtk.css with that content.

/* needed for keyboard layout indicator applet */
.mate-panel-menu-bar {
    color: @fg_color;
}

and reload session for restarting mate-settings-daemon.
As you can see
/usr/share/themes/Radiance/gtk-3.20/gtk-main.css use another color definition as Radiant-Mate.

@monsta
Copy link
Contributor

monsta commented Apr 27, 2017

@flexiondotorg: I can confirm Radiant-MATE still has this issue, not only in 16.04, but also in 16.10 and 17.04. I see @raveit65 fixed it, but I'm not sure if an SRU would be allowed for this change...

@monsta
Copy link
Contributor

monsta commented May 12, 2017

Happens with GTK+ 3.14 as well, but with a weird effect: the indicator has light green + white colors (with a gradient), at least in my VM. This looks quite funny with BlackMATE theme. 🙂

Reopening, we need to get this fixed for any theme and any GTK+ version...

@monsta monsta reopened this May 12, 2017
@flexiondotorg flexiondotorg changed the title [GTK+3] Keyboard layout indicator text in the panel is always white [GTK+3] Keyboard layout indicator text in the panel is always white [$10] Aug 12, 2017
@N0rbert
Copy link

N0rbert commented Jan 3, 2018

From my wrongly reported bug:

Steps to reproduce:

  1. Install Ubuntu 18.04 LTS
  2. Install ubuntu-mate-desktop
  3. Set light theme from mate-control-center Appearance - for example darkroom:
    darkroom

Expected results:

  • keyboard layout indicator is visible on light and dark themes

Actual results:

  • keyboard layout indicator has low contrast on light themes

MATE general version

1.18.4

Linux Distribution

Ubuntu 18.04 LTS

Link to downstream report of your Distribution

Issue filed to the launchpad as bug 1728711.

@raveit65
Copy link
Member

Reopening, we need to get this fixed for any theme and any GTK+ version...

Any one working on that?
This is fixed in Mate themes an Ubuntu Mate themes.
I see no reason to let a report open if no one is working on that.

@tamplan
Copy link
Contributor

tamplan commented Jun 16, 2019

I can't reproduce this bug on fedora 30 with libmatekbd 1.23 (master) with light theme:
Capture du 2019-06-16 22-19-19

Regards

@max-dw-i
Copy link

Still can reproduce with any non-standard light theme (which do not have the fix from #28 (comment)).
MATE v1.24.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants