Fix losing title of windows with a 3 or 4 bytes first character #758
Conversation
There was a problem hiding this comment.
Builds clean, and fixes the issue though with my fonts I only get the missing-character symbols. Without this the space stays entirely empty however, so this should confirm it works. Someone with the appropriate fonts installed ideally would also test this, but I doubt the characters themselves would change with this as opposed to whether they are displayed
|
@lukefromdc it shouldn't change anything, but here I get proper characters (well, I see Chinese characters, and assume it's the right ones :)) and it works |
|
@cloudfish Can you please test PR |
|
I have no idea what's wrong with https://zh.wikipedia.org/ on my fedora system. Chinese symbols are in the middle of the window title. Without a screenshot from reporter i would say it's debian specific :) |
|
I can confirm now the issue, sadly the bad commit is in latest 1.26. release. |
|
@raveit65 hopefully @cloudfish will be able to test, but this is a very simple fix I am confident in. If you confirm it fixes the Firefox example for you as well we should be good. A maybe more important test is whether it doesn't break #749 -- but my tests with KCalc tell me it doesn't -- and the logic I see agrees. |
|
If it is urgent Debian maintainer can use it as patch for his build. |
|
@mate-desktop/core-team can I cherry-pick this in 1.26? We have the breaking change there, and it's affecting distros that might or might not know about it. |
|
Cherry-picked as a938884 |
Fixes #757.