UI: replace all deprecated elements

[raveit65]

Please test.

[lukefromdc]

I did not find any noticeable differences in appearance or behavior with a quick test (open mate-calc, punch in some numbers, test keys known to pop up menus). Did not test calculations for accuracy but this should not be affected.

[vkareh]

Works well. I opened all these files in Glade and I could not see any warnings whatsoever - great work! :)

[sc0w]

There is one more deprecation, stock items, glade never shows us it, I reported it in the past:

https://gitlab.gnome.org/GNOME/glade/issues/289

@raveit65 I can add one more commit here to fix it if you agree :)

[raveit65]

@sc0w
Oh i didn't know that. Of course i agree with adding commits here :)

[sc0w]

ok, done

[vkareh]

Still works well with the new change. Thanks!

[raveit65]

Hmm, last commit breaks the dialogs in eg. financial mode.
I got this warning

[rave@mother ~]$ mate-calc

** (mate-calc:6710): WARNING **: 09:57:48.701: Error loading button UI: /usr/share/mate-calc/buttons-financial.ui:37:41 Object with ID image1 not found

and 'cancel buttons' doesn't have a icon any more.
Also, it seems that the buttons lost functions. Try to use the rate dialog.
Before:

After:

[sc0w]

I did some changes

@vkareh @lukefromdc @raveit65 please test again

[lukefromdc]

The cancel button is back, but somewhere in this we've picked up some out of position combo box menus. Image coming

[lukefromdc]

This happened sporadically, not all the time so when it happened I had to use a camera rather than a screenshot to capture it. In case you can't tell, the button reading "Degrees" is the active one the menu is supposed to be attached to

[raveit65]

I can reproduce this with master too, so it's not related to UI changes here.
You need to open the comboboxes in financial mode first , than try to open the comboboxes in advanced mode. A little video which demonstrate it. (5.7 MB)
https://www.dropbox.com/s/jf8axx21u4xlhi3/mate-calc.ogv.tar.xz?dl=0
Can you please file another report for this new issue?

[lukefromdc]

I too just confirmed this with master, so this PR should be OK. New issue reported at
#56

[raveit65]

Icons and function for buttons are back with latest change.