New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terminal search issues #121
Comments
it's better to use preferred terminal instead of increasing hard coded terminals |
There is already code to use preferred terminal first |
@rezso Assuming the preferred terminal app is set, where is this causing issues exactly? |
I do see a problem in mate-panel as xdg-terminal is no more, https://github.com/mate-desktop/mate-panel/blob/master/mate-panel/libegg/eggdesktopfile.c#L774 |
@infirit: it's possible to set the preferred terminal via GUI? And what happens, if the preferred terminal is missing? F. ex. removed by mistake, or broken. |
Yes, with
Why not try it and see what happens.. If I remember removing the default will cause another to be set automatically. But then as fall-back MATE tries mate-terminal and as a fall-back to the fall-back it tries a few common ones.
You still have not told us where this is causing you actual problems? Because I doubt it is in this function and more likely in the places I linked to. |
Okay, I found anything... this is a glib issue, but where is used the prepend_terminal_to_vector() glib function (https://git.gnome.org/browse/glib/tree/gio/gdesktopappinfo.c#n2360) in mate? |
It is not used anywhere in MATE afaik. I pointed to the two places where I think this goes wrong earlier, see #121 (comment) edit: small correction |
Okay, but if I apply this patch to glib, the problem is solved. So I use a patched glib now. |
The „Failed to execute child process” comes from here: |
I think, the mate_desktop_prepend_terminal_to_vector() never used: |
I added a g_warning just before the call to gtk_show_uri and it is never used for the menu and panel launchers. Which is how it should be as gtk_show_uri is only used for urls. |
I tracked it down to panel_app_info_launch_uris in https://github.com/mate-desktop/mate-panel/blob/master/mate-panel/libpanel-util/panel-launch.c#L97 And it does not look like an easy fix unfortunately. |
IMHO, glib will never be patched for mate :-( The fix has to be done in mate and, as said before, is not easy. ln -s /usr/bin/mate-terminal /usr/bin/gnome-terminal It will not respect the preferred terminal, but at least will schedule the mate-terminal. |
There seems to be two issues
|
Time to close it and open new issues in relevant projects. This is not related to |
The mate_desktop_prepend_terminal_to_vector() tries to find a terminal.
This is a good thing, but:
My solution for these issues:
https://gist.github.com/rezso/5e08ab28dfcb8e4b12d6
The text was updated successfully, but these errors were encountered: