Resize indicator icons to fit panel

[vkareh]

This fixes two issues:

• Some indicators have icons that are not the correct size (e.g. scalable 256px) and so they clip on the panel and look ugly.
• When resizing the panel, indicators stay the same size. This updates the indicator icons so that they resize along with the panel.

Fixes #29

[vkareh]

Notice the VLC, SpiderOak and Slack icons.

Before:

After:

Resizing the panel should also auto-scale the icons now.

[raveit65]

This should be reviewed by someone who use and build it for his distro.
Sorry, i never build or use it for fedora.

[vkareh]

@raveit65 - I know, this doesn't apply to you ;)

Actually, I've never been able to successfully build this on Fedora, but I'm not that concerned about that

[lukefromdc]

While I've only ever gotten this to actually show my indicators ONCE on Debian Unstable, the code looks mostly OK on first examination. I do see

/* Track panel resize */
	g_signal_connect(applet, "change-size", G_CALLBACK(entry_resized), io);

but don't see anything added disconnecting it when the applet is removed or the panel destroyed. Is that already taken care of for all signals used by the indicator applet elsewhere, as is sometimes the case? If so nothing to worry about. Test would be to add and remove the applet whiile watching syslog for any errors involving that signal.

I don't see any obvious memory management errors of the newly dynamically allocated variables (as opposed to new pointers to existing variables) not getting freed sort.

Just commenting as running this on Debian always gets "no indicators" even though I have network-manager-applet running in indicator mode (and it ought to support this). That is true even when the normal mate-panel tray applet(with its own SNI support) is removed from the panel.

[raveit65]

Actually, I've never been able to successfully build this on Fedora, but I'm not that concerned about that

Fedora ships libindicator for building, but there isn't an indicator for using ;)

[selectiveduplicate]

I've been waiting for this to be fixed for a long time! Thanks a lot...
I'll test this on a UM virtual machine as soon as I can, hopefully today... 🙂

[vkareh]

@lukefromdc - since the signal is emitted by the applet itself, it will be disconnected automatically when the applet is destroyed. The main use-case for explicitly disconnecting the signal is when using GObject instances, so this should be memory-safe, as far as I understand it.

To get this running on Ubuntu 19.04 was a bit of a pain, but finally managed using the following flags:

./autogen.sh --prefix=/usr --disable-static --libexecdir=/usr/lib/mate-indicator-applet --with-ubuntu-indicators=yes --libdir=/usr/lib/x86_64-linux-gnu --sysconfdir=/etc --enable-shared=yes --disable-maintainer-mode

[selectiveduplicate]

Some icons still get cropped, for example in the attached image "qbittorrent" gets cropped while VLC is okay...

[vkareh]

@selectiveduplicate - seems theme-specific. Every other theme I tried shows qbittorrent correctly, except for Ambiant. Maybe there's some padding issue in the Ambiant panel?

[muktupavels]

I would say that hard-coded padding #define PANEL_PADDING 8 is problem...

[vkareh]

@muktupavels - true, I don't like it either, but it's the one thing that made it consistently look good across themes. Smaller padding and icons start clipping, more padding and icons look too small... I can increase the padding to take into account whatever other stray indicator icons do, but where to stop?

[muktupavels]

The main use-case for explicitly disconnecting the signal is when using GObject instances

Is that bad wording? Or what did you try to say?

You must disconnect signal if you know that object you connect to will live longer then user_data. You really don't want that callback is called with already destroyed/freed object/data.

If both things are gobjects you can use g_signal_connect_object.

Hard-coded values are rarely good, no? As you say - "where to stop?"... Answer is simple, don't hard-code. I am sure that you should be able to get available space / height.

[selectiveduplicate]

@vkareh Yeah, seems to be theme-specific. All the other themes (the ones that mate-themes ships) work fine without any cropping...

[vkareh]

@muktupavels - thanks, I was misunderstanding this. I can see now on Memory management of signal handlers what you're saying regarding gobjects. I've updated the connect call to using g_signal_connect_object.

[flexiondotorg]

This is a huge improvement! Confirming this as fixing the oversized icons with the added benefit that some indicators icons were also way too small and now they are correctly scaled.

[jrbastien]

I know this change is closed but I think it introduced a problem with large panels. I used to have a nice Windows10 like panel but after upgrade to 19.10 all my indicators icons are as big as the application icons.

I'm trying to build a version prior to this change to confirm this and to possibly adjust the code to have some proportional padding but I get this error: "configure: error: Either Ayatana Indicators or Ubuntu Indicators are required to build mate-indicator-applet."

Assuming I have either one of the two with default Mate 19.10, what am I missing?