Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help compilation to Ubuntu's users #46

Closed
wants to merge 1 commit into from
Closed

Add help compilation to Ubuntu's users #46

wants to merge 1 commit into from

Conversation

tamplan
Copy link
Contributor

@tamplan tamplan commented Jun 27, 2019

On Ubuntu 19.04, without this PR, i have got this message:

Either Ayatana Indicators or Ubuntu Indicators are required to build mate-indicator-applet.

with no more help (including README file).

Regards

@@ -129,7 +129,7 @@ elif test "x$have_ubuntuindicator" != "xyes" &&

else

AC_MSG_ERROR([Either Ayatana Indicators or Ubuntu Indicators are required to build mate-indicator-applet.])
AC_MSG_ERROR([Either Ayatana Indicators (--with-ayatana-indicators) or Ubuntu Indicators (--with-ubuntu-indicators) are required to build mate-indicator-applet.])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me. IIUC, the problem is that the case where you have both Ayatana and Ubuntu indicators is not handled, so results in an error telling you you don't have any instead of both.

IMO the whole test chain should be modified to be simpler and test it all, something like that:

if test "x$with_ayatana_indicators" = "xyes"; then
    use_ayatanaindicator=yes;
    indicator_enforced=yes;
elif test "x$with_ubuntu_indicators" = "xyes"; then
    use_ubuntuindicator=yes;
    indicator_enforced=yes;
elif test "x$have_ayatanaindicator" = "xyes"; then
    use_ayatanaindicator=yes;
    indicator_enforced=no;
elif test "x$have_ubuntuindicator" = "xyes"; then
    use_ubuntuindicator=yes;
    indicator_enforced=no;
else
    AC_MSG_ERROR([Either Ayatana Indicators or Ubuntu Indicators are required to build mate-indicator-applet.])
fi

it doesn't show special messages when one is requested but the other is present, and it selects one over the other if both are present (here, Ayatana's, but it can be swapped easily if wanted -- I have no idea which one should be "best"); but it should cover all cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunweaver: can you please have a look at this...?

@tamplan
Copy link
Contributor Author

tamplan commented Jul 2, 2019

Ok, to be clear, launching just the ./autogen.sh script, i have got the message yet mentioned but informations to compile correctly are given using the command ./configure -h.

Perhaps, and you are right, a better test chain should be studied here to not block the user to compile.

Thanks for your help!

@raveit65
Copy link
Member

Any progress or can this be closed?

@raveit65
Copy link
Member

The description Ubuntu Indicators is misleading. It's called simply libindicatoror libindicator-gtk3-devel in fedora.
https://launchpad.net/libindicator

@raveit65 raveit65 closed this Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants