Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suppress the shutdown menu on LTSP clients #535

Closed
alkisg opened this issue Mar 16, 2017 · 4 comments
Closed

Don't suppress the shutdown menu on LTSP clients #535

alkisg opened this issue Mar 16, 2017 · 4 comments

Comments

@alkisg
Copy link

alkisg commented Mar 16, 2017

This commit, 9 years ago, aimed at hiding the shutdown menu on LTSP clients, because they were remote sessions to the LTSP server, and we didn't want remote users to shut down the server by accident.

Nowadays it prevents LTSP fat clients from shutting down. Fat clients is the recommended LTSP setup, and they run the session locally on the client, so having a shutdown button there is required.
As for thin clients, preventing server shutdown is taken care of by policykit, there's no need to check for an environment variable in the MATE code (btw I'm an LTSP developer).

So, I'd like to ask you to please revert commit 8c25e1b.

@raveit65
Copy link
Member

@lukefromdc
@monsta
@XRevan86
Can we do that?

@alkisg
What is a LTSP client?

@alkisg
Copy link
Author

alkisg commented Mar 17, 2017

@raveit65, LTSP (ltsp.org, Linux Terminal Server Project) is a collection of packages that helps sysadmins set up DHCP, TFTP, NBD, SSHFS etc, so that diskless clients can be booted from the network.
One way to test the problem is to manually set that environment variable, e.g.:
LTSP_CLIENT=1.2.3.4 mate-panel --replace
You'll see then that

  1. Initially, the shutdown menu item is hidden, and
  2. After reverting that 9 year old commit, the shutdown menu item is properly shown again.

I'm testing with mate-panel's redmond layout, because the ubuntu-mate layout doesn't include the shutdown menu item anyway.

@sbalneav
Copy link
Contributor

I support reverting this; it won't affect anyone other than LTSP clients, and we don't need that in there anymore.

@lukefromdc
Copy link
Member

I can confirm that mate-panel in master as of today suppresses the shutdown item in the main menu (shutdown applet from mate-applets unaffected) when restarted with
LTSP_CLIENT=1.2.3.4 mate-panel --replace
though I have never worked with a diskless client that I controlled.

monsta pushed a commit that referenced this issue Mar 20, 2017
This reverts commit 8c25e1b.
LTSP no longer requires this, and it in fact prevents LTSP machines from
shutting down.

Closes #535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants