Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: allow workspace looping with repeatedly pressed keyboard shortcuts in workspace switcher applet when wrap around is enabled #969

Open
N0rbert opened this issue May 13, 2019 · 21 comments

Comments

@N0rbert
Copy link

N0rbert commented May 13, 2019

Expected behaviour

Workspace switching is done in a loop (wrap around) by one of the following methods:

  • rotating mouse wheel above Workspace Switcher applet
  • interpreting keypresses on <Ctrl+Alt+ → > repeatedly (or <Ctrl+Alt+ ← > )

Actual behaviour

Workspace switching is done in a loop only by mouse.
Pressing <Ctrl+Alt+ → > repeatedly (or <Ctrl+Alt+ ← > ) moves to the last or to the first workspace.

Steps to reproduce the behaviour

  1. Right click on Workspace Switcher, select Preferences, check [v] Allow workspace wrap around in switcher (or run dconf write /org/mate/panel/objects/workspace-switcher/prefs/wrap-workspaces 'true')
  2. Press <Ctrl+Alt+ → > repeatedly (or <Ctrl+Alt+ ← > )

MATE general version

1.22.1 (but really it exists since MATE 1.8.1 as in Ubuntu 12.04 LTS with MATE for Precise PPA)

Package version

1.22.1-0ubuntu1

Linux Distribution

Ubuntu 19.10

Link to downstream report of your Distribution

This is long story, ended here - https://bugs.launchpad.net/ubuntu-mate/+bug/1828842 .

@vkareh
Copy link
Member

vkareh commented May 13, 2019

The best way to address this would be to synchronize the toggle in the workspace-switcher (org.mate.panel.applet.workspace-switcher wrap-workspaces) with the one in marco (org.mate.Marco.general wrap-style).

That means changing the checkbox to either a radio or a dropdown with the options for:

  • No wrap
  • Classic
  • Toroidal

The behavior when scrolling on the applet would also need to be modified to support the Classic versus Toroidal options.

Then we can just get rid of org.mate.panel.applet.workspace-switcher wrap-workspaces, as it would be redundant.

@knopancakes
Copy link

@vkareh I like how you're thinking, consolidating the settings into a drop down. This should make the workspace settings feel less fragmented.

@vkareh
Copy link
Member

vkareh commented May 13, 2019

The main question is what to do with Compiz/Metacity... we could disable it for non-marco window managers, as Compiz has its own UI for configuration...

the other alternative is to get rid of this toggle in the applet and add it instead to the mate-window-properties...

@knopancakes
Copy link

To be honest, I was surprised not to find this setting under mate-window-properties or mate-tweak when I first went looking. Perhaps mate-tweak would be a better candidate since it also has context for selecting the window manager?

@knopancakes
Copy link

But now that's going to open another can of worms, there being duplicate settings in mate-tweak/Windows and mate-window-properties

@vkareh
Copy link
Member

vkareh commented May 13, 2019

possibly... you could put a request there. However, mate-tweak for now is Ubuntu-only... Fedora, for example, doesn't ship with it. So if we remove the toggle from the applet, then Fedora users would need to use dconf/gsettings to change it manually...

@vkareh
Copy link
Member

vkareh commented May 13, 2019

another option is to add it to the mate-window-properties and change the text in the workspace-switcher one mentioning it's for mouse-scrolling only, that might be the easiest change of all

@knopancakes
Copy link

knopancakes commented May 13, 2019

Yes, with all that in mind, I think adding to mate-window-properties is probably the cleanest solution. The duplicate settings in mate-tweak are handled okay right now, so adding more should be fine. We also avoid removing functionality for some users by simply cleaning up the semantics of the text.

@muesli4
Copy link
Contributor

muesli4 commented May 15, 2019

As I've stated on the launchpad page already, the settings are not related in any way. But people don't read. (And then write rude and childish personal messages to me.)

@vkareh The workspace switcher applet preferences dialog mentions that this setting is for the switcher (in fact there is a setting for each workspace switcher applet). So there could be scenarios where you want to have it enabled in one workspace switcher but not in the other. This is consistent with most other options there except the number of workspaces. In light of that, I don't see any reason for changing the behavior.

@knopancakes If the description is that bad make a proposal for a better toggle button text.

@lukefromdc
Copy link
Member

Mate-tweak on Debian mostly works but lots of python errors and problems saving parts of panel configuration.

@knopancakes
Copy link

knopancakes commented May 16, 2019

@muesli4 You're missing the point, baby. We know the settings aren't technically related, we're saying that there should be some way of controlling them both in a GUI.

For a better name you need two words. "Allow mouse wheel to wrap workspaces in switcher"

@muesli4
Copy link
Contributor

muesli4 commented May 17, 2019

You're missing the point, baby.

@knopancakes Baby? Can we keep this discussion professional, please? (I also do not wish to receive any more personal emails from you.)

We know the settings aren't technically related, we're saying that there should be some way of controlling them both in a GUI.

Well, a day ago you didn't and now you're speaking for everyone. Obviously a lot of people have no clue what's going on. How about you respond to the points I brought up? I invented, implemented and maintained this feature. I can't think of a person that's more qualified to discuss with.

Personally, what I like about MATE is the ability to configure everything to my own needs. Usability over simplicity (because otherwise it would be Gnome 3).

@knopancakes
Copy link

knopancakes commented May 17, 2019

@muesli4 Yeah, baby! It's a colloquialism. You must be mistakenly interpreting it as an insult because you sent me a rude personal email with the same title. And here I thought you were just being friendly...

If you want a professional discussion, don't start out by insulting people. If you don't want to receive personal emails, don't send your own.

I'm not speaking for everyone, I'm speaking for myself and for the others who have directly contributed to this conversation (vkareh).

I responded to every single point you brought up... maybe you didn't read because you were too busy repeating that the settings aren't related. Some discussion. Now I understand why you're so defensive about this, your ego is clearly overinflated.

At least this we can agree on.

@N0rbert
Copy link
Author

N0rbert commented May 17, 2019

I can't understand what is going on here. The linked LP 1828842 bug was reported by Theodor (hoffer-schaefer.theo), but here we did not hear from him. I filed this bug here to inform upstream developers.

Instead we have non-pleasant discussion with rude and non-technical behavior... What was the final target?

@raveit65
Copy link
Member

Can please stop speaking like white-trash people?
Next time i will lock topic.

@knopancakes
Copy link

knopancakes commented May 17, 2019

@N0rbert hoffer-schaefer.theo is me.

I proposed an improved text description of the toggle button that controls mouse wheel behavior.

There was some discussion about adding a feature in mate-window-properties to control org.mate.Marco.WrapStyle, but I still feel strongly that the workspace-switcher is a more sensible place.

I don't think we've reached a consensus, as some of us feel that the settings are not related in any way despite them both having "workspace" and "wrap" in the name and affected functionality.

@muesli4
Copy link
Contributor

muesli4 commented May 18, 2019

I requested more information from another bug report because he wouldn't tell me his version and did not read what I was writing. That's when he started sending me emails via launchpad (to which I responded, which obviously was my mistake). Also, just look at the history of @knopancakes post, he intentionally added baby to provoke me (context). I just want to clarify this because I don't like being slandered.

I've wrote everything there is to write about the topic here:

#969 (comment)

The workspace switcher applet preferences dialog mentions that this setting is for the switcher (in fact there is a setting for each workspace switcher applet). So there could be scenarios where you want to have it enabled in one workspace switcher but not in the other. This is consistent with most other options there except the number of workspaces. In light of that, I don't see any reason for changing the behavior.

That's basically what keeps this setting from being centralized. No response to that so far.

I don't think we've reached a consensus, as some of us feel that the settings are not related in any way despite them both having "workspace" and "wrap" in the name and affected functionality.

@knopancakes Because those settings are related to the behavior of two different application and one of them (workspace-switcher-applet which is part of mate-panel) can have several different instances with different settings. I see the following alternatives:

  • Remove the setting per workspace-switcher-applet and use a centralized one. Loss of functionality.
  • Keep everything as is and improve text and documentation.

As for mate-tweak: You can still access this setting and display it. However, I don't think we should feel pressured to change anything to the worse just to make it easier for an external tool.

@knopancakes
Copy link

knopancakes commented May 18, 2019

@muesli4 It takes two to tango my man. I don't like being referred to as illiterate. I can read, my mind just works differently than yours. I'm asking for the text to be improved for numbskulls like myself who can read just fine but think in a different context.

So there could be scenarios where you want to have it enabled in one workspace switcher but not in the other.

Understood, the mouse wheel setting cannot be centralized. The context of that setting was misunderstood, but now that we have clarity this is not what is being asked for.

This is consistent with most other options there except the number of workspaces

The application is called worspace-switcher-applet, and it already has hooks to manipulate settings like the number of workspaces (which is technically part of a different application).

Don't remove anything, but rather extend the functionality. I think it's fitting for the application to have control over such settings as org.mate.Marco.WrapStyle, because to me they have very similar context.

I have the following, and I see no way whatsoever to control org.mate.Marco.WrapStyle:

~> apt-cache policy mate-tweak
mate-tweak:
  Installed: 18.04.16-1
  Candidate: 18.04.16-1
  Version table:
 *** 18.04.16-1 500
        500 http://us.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu bionic/universe i386 Packages
        100 /var/lib/dpkg/status

@raveit65
Copy link
Member

mate-tweak is a third party tool from ubuntu-mate.
Why not using dconf-editor (GUI) like users in other distros like fedora?
Here you'll find all gsettings keys for Mate and it has a search function.
Or is this too difficult for you?

@knopancakes
Copy link

knopancakes commented May 18, 2019

I know mate-tweak is a third party tool. You cannot access this setting and display it through mate-tweak. Let us not discuss mate-tweak.

dconf-editor works fine. So does the terminal. That doesn't mean that there aren't better ways. I shouldn't have to go looking for gsettings keys for basic stuff like this, especially when there's a half-finished interface already there.

If I wanted my system to look and behave like Fedora, I'd use Fedora instead of Ubuntu. My concerns lie with the workspace switcher application in the context of mate-desktop on Ubuntu. Apparently reading is too difficult for you?

The existing implementation of mate-workspace-switcher contains ambiguity, and I'm simply suggesting an improvement to the cohesiveness of the switcher application and desktop environment as a whole. I don't understand why you @raveit65 and @muesli4 are so opposed.

@vkareh
Copy link
Member

vkareh commented May 18, 2019

I'd be happy to review a pull request implementing either the feature request or the change in text.

If there's merit in the change, and other MATE core members approve, we might merge it.

This conversation is now taking time from actual development and decision making. I'm OK if we lock this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants