panel-util: avoid X11-specific header #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message is misleading. Why in gtk3? |
|
It shoud be |
panel-util.c:31:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
^~~~~~~~~~~~
|
@jbeich Please, change the subjects of the pull request and the commit message to make easier the tracking at first sight. For instance, you can add the name of the modified file, since only one file is modified. Next, you can add a summary of the change that other developers can uniquely understand.
Try to keep commit message subject under 72 characters. |
jbeich
changed the title
|
@rbuj, is it good enough now or do PR description and commit message have to match? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with
--disable-x11(Wayland-only) one X11-related header appears to be included outside of#ifdef HAVE_X11. However, Gtk+ 3 only installs the header if built with--enable-x11-backend.