Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window list #1252

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Fix window list #1252

merged 2 commits into from
Sep 2, 2021

Conversation

mbkma
Copy link
Member

@mbkma mbkma commented Sep 1, 2021

I messed up somewhat with commit bcfc525: I did not notice that they used the ::changed signal on purpose to make the properties dialog work even when changing the settings in dconf-editor for example.

This PR reverts that commit but retains the UI file changes (GtkNotebook) made in #1223 and fixes the thumbnails checkbox (which had no effect before #1223 ).

Please test that all options are remembered after mate-panel --replace and that the properties dialog respond to changes made with dconf-editor.

Fixes #1250 (This should probably be in 1.26.1)

adapt ui file to reverted window-list.c
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and fixes two problems:

1: the window grouping settings configured by the user are now saved across restarts of mate-panel (as they were always supposed to be)

2: Turning window thumbnails on or off is now applied immediately

@lukefromdc lukefromdc requested a review from a team September 1, 2021 19:00
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All windows-list settingsare ther after a session restart

@raveit65
Copy link
Member

raveit65 commented Sep 1, 2021

@vkareh
Please can you do a review?
.....before i make another bogus release.

@vkareh vkareh self-requested a review September 2, 2021 12:11
Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows list problem: loss of config
4 participants