Gettext

[yetist]

No description provided.

[raveit65]

If you don't want to merge meson PRs, e.g. mozo,
it doesn't makes sense to merge/review gettext PRs for me, because make dist is broken with gettext.
And i need this for releasing developer releases.

[yetist]

If you don't want to merge meson PRs, e.g. mozo,
it doesn't makes sense to merge/review gettext PRs for me, because make dist is broken with gettext.
And i need this for releasing developer releases.

Mozo is different, it use new feature of meson-0.50.0, but the current version is 0.49.2 on debian/ubuntu, so it can't build and create tarball on debian/ubuntu, but can create tarball on archlinux/fedora for release, it's enough. After user get the tarball, they can use autotools to install/uninstall.

The other repos may not need the new feature of meson, for example mate-backgrounds use meson-0.41.0.

[rbuj]

LGTM. It seems that it didn't lose any message.

$ ./autogen.sh --prefix=/usr && ./makepot
$ grep "\.ui" mate-session-manager.pot | wc -l
16
$ git diff --stat mate-session-manager.pot
...
 1 file changed, 168 insertions(+), 136 deletions(-)
$ make distcheck
...
=============================================================
mate-session-manager-1.23.0 archives ready for distribution: 
mate-session-manager-1.23.0.tar.xz
=============================================================

[lukefromdc]

I can confirm mate-distcheck completes fine on Debian Unstable with this:

=============================================================
mate-session-manager-1.23.0 archives ready for distribution: 
mate-session-manager-1.23.0.tar.xz
=============================================================
luke@ubuntu:~/Desktop/mate-session-manager$ 

Did not test installing for a new session as this does not appear to change the built binaries and I would have to log back into github et all to report the results. I did check the mate-session-properties(startup applications) desktop file for function and it worked fine

[lukefromdc]

We've already merged meson PR's for mate-desktop and mozo, so we need these now

[raveit65]

Please check tarballs!
make distcheck creates .gmo and .po files in tarball.
That means we ship broken tarballs when this is merged.
The solution is to port to meson and using ninja -C build dist to create a tarball.
I suggest finishing this 2 ports for every repo before start porting to gettext in every repo,
and make distcheck is broken everywhere.

PS: marco is ported to gettext but meson port is missing.

Edit: see here for references mate-desktop/mate-backgrounds#22 (comment)

[raveit65]

LGTM and it builds fine.
see my previous comment about problem with generated tarball.

[lukefromdc]

I don't know enough about .gmo and .po files to make a valid check, unless we just want absence or presence of either one. I just checked to see that make-distcheck completed, then asked for other reviews.

I agree with this and meson ports being one after the other given the issue with tarballs.

[yetist]

Fix make dist to remove gmo files, result is here:
https://travis-ci.org/mate-desktop/mate-session-manager/jobs/549059011#L2214

[raveit65]

Thanks again for this fix. Now we can merge this.

[raveit65]

@yetist
sorry, for asking you again, but we have 3 desktop files here which contain icon and keyword entry.
Can you add translators hints please?

[raveit65]

@yetist
Done, please review and merge.
#225