Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make libglesv2 optional #237

Merged
merged 1 commit into from
Apr 3, 2020
Merged

build: make libglesv2 optional #237

merged 1 commit into from
Apr 3, 2020

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Apr 1, 2020

Closes #236

vkareh
vkareh approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Compiled successfully:

  • With mesa-libGLES-devel not installed
  • With mesa-libGLES-devel installed
  • --without-libglesv2
  • --with-libglesv2
    All seem to build and run fine on my side

raveit65
raveit65 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
make distcheck runs successfully.

@raveit65 raveit65 merged commit cbbf133 into master Apr 3, 2020
@raveit65 raveit65 deleted the glesv2-optional branch April 3, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkareh vkareh vkareh approved these changes

@raveit65 raveit65 raveit65 approved these changes

@sc0w sc0w sc0w approved these changes

@clefebvre clefebvre Awaiting requested review from clefebvre

@cwendling cwendling Awaiting requested review from cwendling

@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg

@lukefromdc lukefromdc Awaiting requested review from lukefromdc

@monsta monsta Awaiting requested review from monsta

@sunweaver sunweaver Awaiting requested review from sunweaver

@yetist yetist Awaiting requested review from yetist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mate_session_check_accelerate helpers do not compile if libGLESv2 is not available
4 participants
@rbuj @vkareh @raveit65 @sc0w