Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsm-inhibit-dialog: Fix -Wimplicit-int-float-conversion warnings #293

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Dec 14, 2021

gsm-inhibit-dialog.c:311:38: warning: implicit conversion from 'int' to 'float' may lose precision [-Wimplicit-int-float-conversion]
                int scale_x = (int) (pw * scale_factor);
                                     ^~ ~
---
gsm-inhibit-dialog.c:312:38: warning: implicit conversion from 'int' to 'float' may lose precision [-Wimplicit-int-float-conversion]
                int scale_y = (int) (ph * scale_factor);
                                     ^~ ~

@rbuj rbuj closed this Apr 15, 2023
@raveit65 raveit65 reopened this Apr 16, 2023
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
warning is gone, tested and application runs well.

@raveit65 raveit65 requested a review from a team April 19, 2023 15:00
Copy link
Member

@zhuyaliang zhuyaliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning fixed

@zhuyaliang zhuyaliang merged commit 0c8e58a into master Apr 20, 2023
@zhuyaliang zhuyaliang deleted the implicit-int-float-conversion branch April 20, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants