Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move D-Bus conf file to $(datadir)/dbus-1/system.d #296

Closed
wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Since D-Bus 1.9.18 configuration files installed by third-party should
go in share/dbus-1/system.d. The old location is for sysadmin overrides.

Since D-Bus 1.9.18 configuration files installed by third-party should
go in share/dbus-1/system.d. The old location is for sysadmin overrides.
@raveit65 raveit65 requested a review from a team September 27, 2019 14:01
@raveit65
Copy link
Member

Do you have a link to docs about this change?

@worldofpeace
Copy link
Contributor Author

See https://dbus.freedesktop.org/doc/dbus-daemon.1.html CONFIGURATION FILE

The standard system bus normally reads additional XML files from /usr/share/dbus-1/system.d. Third-party packages should install the default policies necessary for correct operation into that directory, which has been supported since dbus 1.10 (released in 2015).
The standard system bus normally also reads XML files from /etc/dbus-1/system.d, which should be used by system administrators if they wish to override default policies.
Third-party packages would historically install XML files into /etc/dbus-1/system.d, but this practice is now considered to be deprecated: that directory should be treated as reserved for the system administrator.

@lukefromdc
Copy link
Member

How do I test this? Does Pluma's date/time plugin get its information from this and provide a valid test, or does something else use it? The panel clock seems to work the same even if I disable this plugin in dconf-editor and restart m-s-d

@worldofpeace
Copy link
Contributor Author

I believe the .conf file that is installed is https://github.com/mate-desktop/mate-settings-daemon/blob/f58866e5d85915ba8e957cd0c6054c392f9d3ffa/plugins/datetime/org.mate.SettingsDaemon.DateTimeMechanism.conf

That conf file says

<!-- Only root can own the service -->

<!-- Allow anyone to invoke methods on the interfaces -->

So you have to check if root owns org.mate.SettingsDaemon.DateTimeMechanism and if anyone can invoke methods on the interface. Probably could test with d-feet.

@lukefromdc
Copy link
Member

I have no idea what d-feet is, but thanks for the instructions. Will leave this for someone who knows what they are doing for a proper test. Might get to a go-nogo "does it function" test but out of time tonight.

@worldofpeace
Copy link
Contributor Author

d-feet is a dbus debugger

Pretty useful tool to play around with dbus as you'd need to here.

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify that /usr/share/dbus-1/system-services/org.mate.SettingsDaemon.DateTimeMechanism.service appears with this
While I do NOT know enough about debus to understand what would happen if this did not work, I can verify that restarting mate-settings-daemon, then mate-panel does not create any problems on changing the system time or displaying the time in the panel.

Someone who knows what this plugin is doing needs to review this

@raveit65 raveit65 requested review from a team October 2, 2019 11:14
@eworm-de
Copy link
Contributor

This one is wrong, see #303.
If you want to change the default please do in configure.ac.

@worldofpeace
Copy link
Contributor Author

Didn't notice that, will PR a default change after that is merged 👍

@worldofpeace worldofpeace deleted the patch-1 branch December 13, 2019 15:41
@worldofpeace worldofpeace restored the patch-1 branch December 13, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants