Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have 'Super+P' trigger a video mode switch. #297

Closed
wants to merge 1 commit into from

Conversation

flexiondotorg
Copy link
Member

Newer Dell and HP systems have a BIOS which causes FN+F8 to send the literal Super+P scan codes instead of a KEY_VIDEOMODE scan code. See https://pad.lv/539477 for the background.

Newer Dell and HP systems have a BIOS which causes FN+F8 to send the literal Super+P scan codes instead of a KEY_VIDEOMODE scan code. See https://pad.lv/539477 for the background.
@flexiondotorg flexiondotorg requested a review from a team September 20, 2019 06:23
@vkareh
Copy link
Member

vkareh commented Sep 20, 2019

Why oh why!! I use Super+P regularly (for corner tiling), a lot more than video mode switches, why would Dell/HP do that?!!?

This patch works, but I would suggest putting it behind a gsettings flag, or (if possible) detect whether the system uses that abherration of a key combo and then enable/disable accordingly.

I have a Lenovo that doesn't suffer from this mis-design, and it would make me sad to lose Super+P on that system...

On a side note, the Keyboard Shortcuts app still lets me map Super+P with no problems (and my laptop does both, corner tiling and video mode switch), but that's outside the scope of this change.

@monsta
Copy link
Contributor

monsta commented Sep 20, 2019

Please no. Both LP and gnome-bugzilla reports are full of comments from users who experienced problems due to this surprise hardcoded keybinding. Let's not repeat a mistake done 9 years ago.

@flexiondotorg
Copy link
Member Author

Super+P is now an industry standard.

@vkareh
Copy link
Member

vkareh commented Sep 21, 2019 via email

@monsta
Copy link
Contributor

monsta commented Sep 24, 2019

I doubt it's some standard if only a few laptop vendors have it. We'll get tons of reports from desktop users for this.

@vkareh
Copy link
Member

vkareh commented Sep 24, 2019 via email

@gm10
Copy link
Contributor

gm10 commented Dec 22, 2019

For what it's worth, my Asus laptop also binds Fn+F8 to Super+P, the same keybind that Windows uses for the video mode switch. So the combination as such is fairly standard and expected indeed and some sort of support for it, optional or not, would be nice.

@lukefromdc
Copy link
Member

Closing due to lack of activity and multiple requests for changes. Can be reopened if someone wants to put this behind a gsettings switch and not make it the default.

@lukefromdc lukefromdc closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants