-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix url highlighting due to deprecation of vte_terminal_match_add_gregex #330
Conversation
I see in I think you don't need the checks |
Oh, so we could drop support for the old way completely, that would simplify the patch. Should I update it? |
yes, please |
Ok, I force pushed now with the checks removed and all switched to VteRegexp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New warning detected in this PR:
|
@sc0w Thanks, I missed that one during the simplification (VTE check removal), pushed a new commit that changes the type. |
now I noticed these warnings, but we have similar warnings in master
|
@sc0w these warnings have been there since before, because the initializers for these structs always were missing the flag value. I guess putting a simple 0 at the end of all would silence the warnings. |
can you fix it here please? |
Ok, I'll add a commit fixing this. Please wait a bit. |
@sc0w I have pushed a trivial fix, but interestingly, I don't see the warning you pasted abvoe about missing initializers. Did you do something special when compiling? Futhermore, there are more things to be fixed: The grexep stuff is still used in the search function, I will look into fixing the search, too. |
@sc0w I have now fixed also the search problem - at least for me searching works again. There is a strange warning message issued while searching:
I checked the API, and passing Anyway, functionality-wise I can at least search with default settings, didn't try to do anything fancy, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No new warnings in the logs, it works as expected, and it fixes a lot of warnings running mate-terminal with xterm:
(mate-terminal:30692): VTE-CRITICAL **: 13:47:42.908: void vte_terminal_match_set_cursor_type(VteTerminal*, int, GdkCursorType): assertion 'tag >= 0' failed
Thanks for merging! |
@norbusan |
@raveit65 Yes, the functionality used is there since vte .48 afair, so if you have 0.58 then it should be no problem to use. |
Fixes Issue 329