Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several MATE themes do not render vala-panel-appmenu applet correctly #207

Closed
flexiondotorg opened this issue Mar 2, 2018 · 13 comments
Closed

Comments

@flexiondotorg
Copy link
Member

flexiondotorg commented Mar 2, 2018

Expected behaviour

When the vala-panel-appmenu Global Menu applet for MATE is added to a panel, the background of the Global Menu applet should use the same background colour as the panel.

Actual behaviour

When the Global Menu applet is used with the following themes the Global Menu applet background doesn't match the panel background.

  • BlackMATE
  • Blue-Submarine
  • GreenLaguna
  • Green-Submarine
  • TraditionalGreen
  • TraditionalBlue

Here is an example screenshot of the issue.

mate-themes-gloabl-menu

Steps to reproduce the behaviour

  • Run the Ubuntu MATE 18.04 daily image live session in a VM
  • Right click a panel, select "Add to panel..", select "Global Application Menu" and add it.
  • Open MATE Terminal.
  • Open Appearence control center applet.
  • Select one of the affected theme listed above, focus the MATE Terminal window and look at the Global Menu.

MATE general version

  • 1.20

Package version

  • mate-themes 3.22.15-0ubuntu1

Linux Distribution

  • Ubuntu MATE 18.04 (daily)

Link to downstream report of your Distribution

  • None
@raveit65
Copy link
Member

raveit65 commented Mar 6, 2018

I would like to fix that but global menu applet doesn't work correctly in my 18.04 installation.
Read my comment in ubuntu-mate/ubuntu-mate-artwork#3 (comment) and followers.

@flexiondotorg
Copy link
Member Author

Try sudo apt install appmenu-gtk2-module appmenu-gtk3-module, reboot and then add the Global Menu to a panel.

@raveit65
Copy link
Member

Already installed.
globalmenu

@flexiondotorg
Copy link
Member Author

@raveit65 Can you try using MATE Tweak to switch layout to Cupertino. That includes the global menu.

@raveit65
Copy link
Member

But the globalmenu is there, only the menu isn't moved from apps to the panel.
I think i tried Cupertino layout already, but i can try it again.

@raveit65
Copy link
Member

Same disappointing result with Cupertino layout.
I see the menus only in panel if the desktop has focus.
Menus from other application won't display in panel with globalmenu.
Note , the installation have latest updates from today.

@raveit65
Copy link
Member

Hmm,
~/.config/dconf/user was owned by root ---> fixed
What is right setting for globalmenu gsettings keys?

rave@ubuntu:~$ gsettings get org.mate.interface gtk-shell-shows-app-menu
true
rave@ubuntu:~$ gsettings get org.mate.interface gtk-shell-shows-menubar
true

@raveit65
Copy link
Member

I notice that other folders and files were owned by root in my user accout.
I never saw that with fedora...
Ok, after deleting and re-creating user account the menus are in panel \o/

raveit65 added a commit that referenced this issue Mar 28, 2018
... on that widget:
.-vala-panel-appmenu-core > scrolledwindow > viewport.frame {}

Using a scrolledwindow and a viewport on top of a menubar
in widget order is really weird.

Fixes #207
@raveit65
Copy link
Member

@flexiondotorg @rilian-la-te
It is quite usual the themes use another background color for GtkFrame in general.
Is there a reason why vala-panel-appmenu use a a scrolledwindow and a viewport there?
This sounds really weird for me, see
vala-panel-appmenu-gtk3-inspector

@sc0w
For TOK themes i'd like to remove the gradient background for the panel at https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/TraditionalOk/gtk-3.0/mate-applications.css#L103
and for

/* main menu */
/* set normal menubar button */
.mate-panel-menu-bar menubar {
    padding: 0px;
    background-image: none;
}

Because the background-image isn't use everywhere for the panel.

@raveit65 raveit65 reopened this Mar 28, 2018
@rilian-la-te
Copy link

  1. It uses scrolling, because if monitor have small resolution, then big menu will move contents of panel out of monitor. With scolling, it will just scrolls.

@flexiondotorg
Copy link
Member Author

@raveit65 In case you missed it, @sc0w gave you a thumbs up to modify TOK 😄

@raveit65
Copy link
Member

It uses scrolling, because if monitor have small resolution, then big menu will move contents of panel out of monitor. With scolling, it will just scrolls.

Ok, that makes sense.

@raveit65
Copy link
Member

done.
2969b74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants