submarine: Specify foreground color in headerbar. #305
Conversation
This fixes Firefox / Thunderbird's inactive tab colors when using CSD, probably others too.
There was a problem hiding this comment.
I got these results in green-submarine and Firefox with this change.
Quite usable, not sure what the prior case was as for some reason I was focussed on the overall headerbar color and the fact that it is set up to be the same in focussed and backdrop windows, which is not how I have my own theme configured and was thus a distraction.
We get one active tab clearly standing out from the inactive tabs, which blend into the rest of the headerbar. Assuming that's the desired behavior.
|
Yeah this fixes the colors of the inactive tab text, same for the menubar if you enable it, see https://bugzilla.mozilla.org/show_bug.cgi?id=1838006 (which was with a theme derived from these). |
|
I will test changes of my themes over the weekend. |
|
Works fine . Thanks for the fix. |
|
Just got bitten by this, and this fixes it, thanks! @mate-desktop/core-team shouldn't we publish this in 3.22.*? It's not in the branch for which the last release was done from, and it's a pretty important fix I'd say, Firefox is not a niche app :) |
|
I don't see any problem with that, keep in mind Firefox often is updated to current versions
without regard for the age of the distro. Nothing says we CAN'T cherrypick to an older release,
it's just not normally done for workload reasons. If software maintained itself, everything would
be an LTS release.
|
This fixes Firefox / Thunderbird's inactive tab colors when using CSD, probably others too.