-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid deprecated gdk_display_get_screen and gdk_screen_get_number #237
Conversation
I think we need GTK_VERSION_CHECK. |
077465e
to
04db9ce
Compare
@raveit65 done! |
Docs say |
Also this changes the format of the internal messages that some plugins might use; did you check that all the plugins still work fine? |
04db9ce
to
077465e
Compare
yes, I think this must work without the checks Commit rebased again
plugins: "external tools", "python console", "quick open" and "snippets" don't work with the tooltip message: "plugin loader 'python' was not found", so, I think it isn't related with the PR, can someone test it? "modelines", "save without trailing spaces" and "tag list", I am not sure how to test, can someone test it? the other plugins are working fine here |
Ah dammit, lack of dependencies... you'll need to install |
I think I'll check the code to find out which plugins actually use the message bus and where/when they do it... |
077465e
to
b1fb782
Compare
commit renamed and rebased with the other files with the deprecations and, I am not sure, we need the checks for gtk in pluma.c? |
b1fb782
to
9c1aa14
Compare
PR updated, and now, I think doesn't change the format of the internal messages that some plugins might use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me now.
Thank you |
No description provided.