Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid deprecated gdk_display_get_screen and gdk_screen_get_number #237

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

sc0w
Copy link
Member

@sc0w sc0w commented Jul 9, 2017

No description provided.

@raveit65
Copy link
Member

I think we need GTK_VERSION_CHECK.
gdk_screen_get_number has been deprecated since version 3.22
https://developer.gnome.org/gdk3/stable/GdkScreen.html#gdk-screen-get-number
gdk_display_get_screen has been deprecated since version 3.20
https://developer.gnome.org/gdk3/stable/GdkDisplay.html#gdk-display-get-screen
Sadly, they use different versions.
@monsta @XRevan86
thoughts?

@sc0w
Copy link
Member Author

sc0w commented Jul 10, 2017

@raveit65 done!

@monsta
Copy link
Contributor

monsta commented Jul 11, 2017

Docs say gdk_display_get_default_screen can be used since 2.2.

@monsta
Copy link
Contributor

monsta commented Jul 11, 2017

Also this changes the format of the internal messages that some plugins might use; did you check that all the plugins still work fine?

@sc0w
Copy link
Member Author

sc0w commented Jul 11, 2017

@monsta

Docs say gdk_display_get_default_screen can be used since 2.2.

yes, I think this must work without the checks

Commit rebased again

Also this changes the format of the internal messages that some plugins might use; did you check that all the plugins still work fine?

plugins:

"external tools", "python console", "quick open" and "snippets" don't work with the tooltip message: "plugin loader 'python' was not found", so, I think it isn't related with the PR, can someone test it?

"modelines", "save without trailing spaces" and "tag list", I am not sure how to test, can someone test it?

the other plugins are working fine here

@monsta
Copy link
Contributor

monsta commented Jul 11, 2017

Ah dammit, lack of dependencies... you'll need to install libpeas-1.0-python2loader package 🙂

@monsta
Copy link
Contributor

monsta commented Jul 11, 2017

I think I'll check the code to find out which plugins actually use the message bus and where/when they do it...

@sc0w
Copy link
Member Author

sc0w commented Jul 11, 2017

commit renamed and rebased with the other files with the deprecations

and, I am not sure, we need the checks for gtk in pluma.c?

@sc0w sc0w changed the title pluma.c Fix: deprecated gdk_display_get_screen and gdk_screen_get_number avoid deprecated gdk_display_get_screen and gdk_screen_get_number Jul 11, 2017
@sc0w
Copy link
Member Author

sc0w commented Jul 13, 2017

@monsta

PR updated, and now, I think doesn't change the format of the internal messages that some plugins might use

Copy link
Contributor

@monsta monsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me now.

@raveit65 raveit65 merged commit 9c1aa14 into mate-desktop:master Jul 14, 2017
@raveit65
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants