Merge pull request #31 from matecat/lokalise-tags

Added SQUARE_SPRINTF type/filter
matecat · Jul 11, 2023 · ad6f491 · ad6f491
2 parents 25c5f17 + 9dd8d9b
commit ad6f491
Show file tree

Hide file tree

Showing 6 changed files with 67 additions and 0 deletions.
diff --git a/src/Enum/CTypeEnum.php b/src/Enum/CTypeEnum.php
@@ -18,4 +18,5 @@ class CTypeEnum {
     const DOUBLE_SQUARE_BRACKETS = 'x-double-square-brackets';
     const DOLLAR_CURLY_BRACKETS  = 'x-dollar-curly-brackets';
     const DOUBLE_UNDERSCORE      = 'x-double-underscore';
+    const SQUARE_SPRINTF         = 'x-square-sprintf';
 }
diff --git a/src/Filters/SquareSprintf.php b/src/Filters/SquareSprintf.php
@@ -0,0 +1,42 @@
+<?php
+
+namespace Matecat\SubFiltering\Filters;
+
+use Matecat\SubFiltering\Commons\AbstractHandler;
+use Matecat\SubFiltering\Enum\CTypeEnum;
+
+class SquareSprintf extends AbstractHandler {
+    /**
+     * @inheritDoc
+     */
+    public function transform( $segment ) {
+
+        $tags = [
+            '\[%s\]',
+            '\[%1$s\]',
+            '\[%s:name\]',
+            '\[%i\]',
+            '\[%1$i\]',
+            '\[%i:name\]',
+            '\[%f\]',
+            '\[%.2f\]',
+            '\[%1$.2f\]',
+            '\[%.2f:name\]',
+        ];
+
+        $regex = '/'.implode("|", $tags).'/';
+
+        preg_match_all( $regex, $segment, $html, PREG_SET_ORDER );
+        foreach ( $html as $pos => $percentSnailVariable ) {
+
+            $segment = preg_replace(
+                    '/' . preg_quote( $percentSnailVariable[ 0 ], '/' ) . '/',
+                    '<ph id="__mtc_' . $this->getPipeline()->getNextId() . '" ctype="' . CTypeEnum::SQUARE_SPRINTF . '" equiv-text="base64:' . base64_encode( $percentSnailVariable[ 0 ] ) . '"/>',
+                    $segment,
+                    1
+            );
+        }
+
+        return $segment;
+    }
+}
diff --git a/src/MateCatFilter.php b/src/MateCatFilter.php
@@ -36,6 +36,7 @@
 use Matecat\SubFiltering\Filters\SpacesToNBSPForView;
 use Matecat\SubFiltering\Filters\SplitPlaceholder;
 use Matecat\SubFiltering\Filters\SprintfToPH;
+use Matecat\SubFiltering\Filters\SquareSprintf;
 use Matecat\SubFiltering\Filters\StandardPHToMateCatCustomPH;
 use Matecat\SubFiltering\Filters\SubFilteredPhToHtml;
 use Matecat\SubFiltering\Filters\TwigToPh;
@@ -167,6 +168,7 @@ public function fromLayer0ToLayer1( $segment ) {
         $channel->addLast( new PercentSnail() );
         $channel->addLast( new PercentNumberSnail() );
         $channel->addLast( new Percentages() );
+        $channel->addLast( new SquareSprintf() );
         $channel->addLast( new SprintfToPH() );
         $channel->addLast( new RestoreXliffTagsContent() );
         $channel->addLast( new RestorePlaceHoldersToXLIFFLtGt() );

diff --git a/src/MyMemoryFilter.php b/src/MyMemoryFilter.php
@@ -31,6 +31,7 @@
 use Matecat\SubFiltering\Filters\Snails;
 use Matecat\SubFiltering\Filters\SplitPlaceholder;
 use Matecat\SubFiltering\Filters\SprintfToPH;
+use Matecat\SubFiltering\Filters\SquareSprintf;
 use Matecat\SubFiltering\Filters\StandardPHToMateCatCustomPH;
 use Matecat\SubFiltering\Filters\SubFilteredPhToHtml;
 use Matecat\SubFiltering\Filters\TwigToPh;
@@ -76,9 +77,11 @@ public function fromLayer0ToLayer1( $segment, $cid = null ) {
         $channel->addLast( new DoubleSquareBrackets() );
         //$channel->addLast( new DoubleUnderscore() );
         $channel->addLast( new DollarCurlyBrackets() );
+
         $channel->addLast( new PercentSnail() );
         $channel->addLast( new PercentNumberSnail() );
         $channel->addLast( new Percentages() );
+        $channel->addLast( new SquareSprintf() );
         $channel->addLast( new SprintfToPH() );
         $channel->addLast( new RestoreXliffTagsContent() );
         $channel->addLast( new RestorePlaceHoldersToXLIFFLtGt() );

diff --git a/tests/MateCatSubFilteringTest.php b/tests/MateCatSubFilteringTest.php
@@ -951,4 +951,14 @@ public function testWithDollarCurlyBrackets() {
         $this->assertEquals( $segment_from_UI, $filter->fromLayer0ToLayer1( $db_segment ) );
     }
 
+    public function testWithSquareSprintf() {
+        $filter = $this->getFilterInstance();
+
+        $db_segment      = 'This string contains [%s]';
+        $segment_from_UI = 'This string contains <ph id="mtc_1" ctype="' . CTypeEnum::SQUARE_SPRINTF . '" equiv-text="base64:WyVzXQ=="/>';
+
+        $this->assertEquals( $db_segment, $filter->fromLayer1ToLayer0( $segment_from_UI ) );
+        $this->assertEquals( $segment_from_UI, $filter->fromLayer0ToLayer1( $db_segment ) );
+    }
+
 }
diff --git a/tests/MyMemorySubFilteringTest.php b/tests/MyMemorySubFilteringTest.php
@@ -205,4 +205,13 @@ public function testWithDollarCurlyBrackets()
         $this->assertEquals( $segment_from_UI, $filter->fromLayer0ToLayer1( $db_segment ) );
     }
 
+    public function testWithSquareSprintf() {
+        $filter = $this->getFilterInstance();
+
+        $db_segment      = 'This string contains [%s]';
+        $segment_from_UI = 'This string contains <ph id="mtc_1" ctype="' . CTypeEnum::SQUARE_SPRINTF . '" equiv-text="base64:WyVzXQ=="/>';
+
+        $this->assertEquals( $db_segment, $filter->fromLayer1ToLayer0( $segment_from_UI ) );
+        $this->assertEquals( $segment_from_UI, $filter->fromLayer0ToLayer1( $db_segment ) );
+    }
 }