Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Cancel button" and a library project #41

Closed
wants to merge 4 commits into from

Conversation

dodikk
Copy link

@dodikk dodikk commented Dec 12, 2012

Added a cancel button.
Added a static library project for better code reuse experience

@matej
Copy link
Owner

matej commented Jun 25, 2013

Thank you for your contribution, but I won't be pulling in those changes at the moment.

Here are the main reasons:

  • I would like to avoid keep this component to two files only and avoid any resource files like bundles
  • iOS 7 is moving away from bordered buttons
  • the code style doesn't quite match the rest of the class
  • there have been significant changes to the project structure in the meantime, including a library target

Neither the less, having some sort of cancellation support has been a frequently requested feature so I'll definitely keep this in mind.

@matej matej closed this Jun 25, 2013
uliluckas pushed a commit to SinnerSchraderMobileMirrors/MBProgressHUD that referenced this pull request Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants