Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta-project-migrate to pass "branch" to splitSubtree() #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaelansmith
Copy link

It seems that splitSubtree() was set up to accept a "branch" parameter, with a default value set to "master"; and the meta-project-migrate script already seems to accept a final command-line argument for "branch" (which isn't documented btw), HOWEVER, the script doesn't actually pass the user-specified "branch" through to splitSubtree() -- so if your main branch isn't called "master" (like mine), the migrate script doesn't work. This PR adds a single-line fix, although untested.

@kaelansmith
Copy link
Author

I now see that this previous PR also addressed this issue and more: #95 -- perhaps it needs to be revisited, or we can at least just merge my simple fix to handle the specific issue of customizing branch name?

I also just saw this past issue: mateodelnorte/meta#281 -- perhaps customizing the branch name via command-line argument doesn't fix all branch-related issues, and the concept of adding a defaultBranch within the .meta config is the better solution (which PR#95 added). If so, should we split up PR#95 so it only focuses on the branch issue and merge that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant