-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a method rowAdd(...) to Matrix #138
Added a method rowAdd(...) to Matrix #138
Conversation
Thanks, will have a look at it this weekend. |
@mateogianolio Super, Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes:
- Don't create a new array unless you really have to (and if you do, use typed arrays). Array instantiation is expensive, especially when using
push()
(needs to reallocate memory every time it's called). - You have two for-loops that loop through the same memory space. They should be combined into one.
See this benchmark: https://jsbench.me/1bjssxmc69/1
|
@mateogianolio Done. I added the preconditions again |
Code Climate has analyzed commit d3faae3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 90.6% (-3.2% change). View more on Code Climate. |
Issue #64
I added the feature as requested:
Inclusive tests