Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to original property not detected properly #100

Open
ghost opened this issue Jun 12, 2022 · 1 comment
Open

Changes to original property not detected properly #100

ghost opened this issue Jun 12, 2022 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 12, 2022

When using the ngx-monaco-diff-editor component, input changes for original are not detected properly.

if (this.editor && ((changes.code && !changes.code.firstChange) || (changes.modified && !changes.modified.firstChange))) {

I guess replacing (changes.code && !changes.code.firstChange) with (changes.original && !changes.original.firstChange) would solve the issue.

Should I create a PR for this?

@arthurhauer
Copy link

In fact, replacing these variables does fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant