[Button] android:background not working #889

0xByteLeon · 2020-01-09T07:54:48Z

Description: after I change my app them to Theme.MaterialComponents.NoActionBar , In my xml file Button label's android:background="@drawable/login_btn_bg" not working,and I can't set others color、shape or selector,they are not work.

Expected behavior: Button label's android:background= can normal work , when I set my app them to Theme.MaterialComponents.NoActionBar or others Material thems

Source code: <style name="CommonAppTheme" parent="Theme.MaterialComponents.NoActionBar">  <item name="colorPrimary">@color/common_colorPrimary</item> <item name="colorPrimaryDark">@color/common_colorPrimaryDark</item> <item name="colorAccent">@color/common_colorAccent</item> <item name="buttonStyle">@style/commonButtonStyle</item> <item name="materialButtonStyle">@style/commonButtonStyle</item> </style>

<?xml version="1.0" encoding="utf-8"?> <resources> <style name="commonButtonStyle" parent="Widget.MaterialComponents.Button"> <item name="android:insetTop">0dp</item> <item name="android:insetBottom">0dp</item> <item name="android:insetLeft">0dp</item> <item name="android:insetRight">0dp</item> <item name="android:minHeight">0dp</item> <item name="android:textColor">@color/common_text_color</item> </style> </resources>
<Button android:id="@+id/btnLogin" android:layout_width="match_parent" android:layout_height="38dp" android:layout_marginLeft="31dp" android:layout_marginTop="61dp" android:layout_marginRight="31dp" android:background="@drawable/btn_bg" android:gravity="center" android:text="@string/common_immediately" android:textSize="15sp" />
Android API version: Android 8.1

Material Library version: 1.0.0

Device: le pro 3

To help us triage faster, please check to make sure you are using the latest version of the library.

We also happily accept pull requests.

The text was updated successfully, but these errors were encountered:

pekingme · 2020-01-09T23:48:17Z

Hi @DreamerLeon, could you try with a newer version of the library? If possible, please provide a sample app to reproduce this issue. It can help us to understand the problem and make a decision to resolve it faster. Thanks.

0xByteLeon · 2020-01-10T01:25:58Z

Hi @DreamerLeon, could you try with a newer version of the library? If possible, please provide a sample app to reproduce this issue. It can help us to understand the problem and make a decision to resolve it faster. Thanks.

New version(1.2.0-alpha03) also has this problem , I will write a demo Later on and post on github ,Thanks for your answer.

0xByteLeon · 2020-01-10T01:59:53Z

Hi @DreamerLeon, could you try with a newer version of the library? If possible, please provide a sample app to reproduce this issue. It can help us to understand the problem and make a decision to resolve it faster. Thanks.

MDCIssueDemo
This project can reproduce this issue.

pekingme · 2020-01-10T20:37:33Z

Thanks @DreamerLeon for the demo. This is a known issue. Currently the solution to this is to set the background programmatically. We are working on a solution for the xml attribute. Hope that it can land soon.

0xByteLeon · 2020-01-14T08:54:17Z

Thanks @DreamerLeon for the demo. This is a known issue. Currently the solution to this is to set the background programmatically. We are working on a solution for the xml attribute. Hope that it can land soon.

Thx for your answer!

hamed8080 · 2020-01-25T06:11:44Z

hope next beta fix this . I need add boilerplate code for background!

ImAreeb · 2020-03-08T20:02:26Z

I am using latest version com.google.android.material:material:1.2.0-alpha05.
This problem still exists. I can't override button color using background attribute in XML

diegoalvis · 2020-03-26T23:21:07Z

Any update of this?
I changed my app theme due crash using Material TabLayout but this broke all the buttons and TextInputLayouts so I rolled back. Looking forward for next beta sadly can't use the TabLayout yet.

0xByteLeon · 2020-04-01T01:24:30Z

@diegoalvis This problem still exits,I hope someone can fix it

wcshi · 2020-04-01T14:26:37Z

Fixed in 309d718

AlejandroHCruz · 2020-04-08T14:37:58Z

Hi, could you make a new alpha release with this fix? It's quite important for me and others :)
Thank you!
@wcshi @hamed8080

pejman-74 · 2020-04-11T13:24:54Z

Stills' waiting.🙄

AlejandroHCruz · 2020-04-13T18:22:29Z

@pejman-74 In case it's useful, my workaround is to use a FrameLayout with an ImageButton and a (Material)TextView

wcshi · 2020-04-13T18:44:47Z

Stay tuned, a new alpha release is coming this week.

KidusMT · 2020-04-17T13:46:16Z

it worked well with the update on: com.google.android.material:material:1.2.0-alpha06

AlejandroHCruz · 2020-04-17T19:18:40Z

Friday release! 🤩🙈

NehaDShakya · 2020-04-20T19:42:12Z

Updated to : com.google.android.material:material:1.2.0-alpha06
Can onlyset button background color to @color/colorPrimary or #00000000.

nicoqueijo · 2020-04-22T03:16:03Z

Still not working for me.

<Button
     android:id="@+id/button_one"
     style="@style/ButtonStyle"
     android:text="@string/button_one" />

<style name="ButtonStyle">
     <item name="android:textSize">32sp</item>
     <item name="android:textColor">@drawable/background_button_text_color</item>
     <item name="android:background">@drawable/background_button</item
</style>

background_button.xml:

<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:drawable="@android:color/white" android:state_pressed="true" />
    <item android:drawable="@android:color/transparent" android:state_pressed="false" />
</selector>

background_button_text_color.xml:

<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:color="@android:color/black" android:state_pressed="true" />
    <item android:color="@android:color/white" android:state_pressed="false" />
</selector>

I am getting a black background instead of white when the button is pressed. Not sure what I'm doing wrong. Any help? I am on 1.2.0-alpha06, btw.

Update: was able to get it working thanks to the help of a couple folks on stackoverflow.

nickruddeni · 2020-04-22T12:31:05Z

Using 1.2.0-alpha06 and still can not override the android:background property with my own xml drawable. I'm using Theme.MaterialComponents.DayNight

nicoqueijo · 2020-04-22T16:15:00Z

@nickruddeni Check the update on the bottom of my post. Might help.

AdislanSaidov · 2020-04-24T15:49:44Z

the same problem. Using 1.2.0-alpha06 , still not working

AdislanSaidov · 2020-04-24T16:12:09Z

solved with app:backgroundTint

dsn5ft · 2020-04-29T13:11:22Z

I think this is because we still set backgroundTint in our default MaterialButton style:

https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/button/res/values/styles.xml#L45

So if you are using a custom android:background, you have to make sure to null out backgroundTint (either app:backgroundTint="@null" or app:backgroundTint="@empty"), so that your custom background doesn't get tinted.

Or, if all you care about is the color of the button, then you can just use app:backgroundTint instead of android:background, but be sure to set it to a color selector like ours to handle disabled state:

https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/button/res/color/mtrl_btn_bg_color_selector.xml

Bhavnaharitsa · 2020-05-11T04:19:50Z

Still not working for me.

<style name="ButtonStyle"> 32sp @drawable/background_button_text_color @drawable/background_button
background_button.xml:

background_button_text_color.xml:

I am getting a black background instead of white when the button is pressed. Not sure what I'm doing wrong. Any help? I am on 1.2.0-alpha06, btw.
Update: was able to get it working thanks to the help of a couple folks on stackoverflow.

Worked like magic, thank you for telling +1

0xByteLeon · 2020-05-11T05:53:38Z

solved with app:backgroundTint

Still not working for me , I set a drawable

Bhavnaharitsa · 2020-05-11T07:24:11Z

solved with app:backgroundTint

Still not working for me , I set a drawable

It doesn't work for drawables, you can only use to change colors and it clears says "tint" :)

AlejandroHCruz · 2020-05-11T08:03:00Z

It didn't work for drawables for me either, see my hack comment above

…

________________________________ De: V Bhavna Haritsa <notifications@github.com> Enviado: lunes, 11 de mayo de 2020 9:24 Para: material-components/material-components-android <material-components-android@noreply.github.com> CC: Alejandro H. Cruz <j.alejandro_1093@hotmail.com>; Comment <comment@noreply.github.com> Asunto: Re: [material-components/material-components-android] [Button] android:background not working (#889) solved with app:backgroundTint Still not working for me , I set a drawable It doesn't work for drawables, you can only use to change colors and it clears says "tint" :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#889 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAOQVOVOJNCN5KW2RVTKV33RQ6R2TANCNFSM4KEUAY2A>.

dsn5ft · 2020-07-22T20:47:22Z

@cutiko If you want to use a custom drawable for CheckBox and disable the Material tinting, can you try setting app:useMaterialThemeColors="false"?

mecoFarid · 2020-08-12T08:00:19Z

Fixed in 309d718

@wcshi

Using:
Library version: 1.2.0
Android version: 29
Device: Pixel 3 emulator

Still not working

wcshi · 2020-08-12T15:20:28Z

@mecoFarid please share a sample app and explain the expected result and observed result.

mecoFarid · 2020-08-12T16:47:54Z

@wcshi Here is the sample project. https://github.com/mecoFarid/MaterialCompButton

Observed result:
Button background color is reset to colorPrimary which is purple in the sample project.

Steps to get the expected result:

In styles extend Theme.AppCompat.Light.DarkActionBar instead of Theme.MaterialComponents.Light.NoActionBar
activity_main.xml use Button instead of com.google.android.material.button.MaterialButton
You'll see a button with a red background which is the expected result.

wcshi · 2020-08-12T16:58:43Z

Did you follow the steps in #889 (comment)?

mecoFarid · 2020-08-12T18:44:22Z

@wcshi It worked, thank you. I love how android SDK is becoming more about painful, hidden workarounds than a smooth development kit.

varunam · 2020-08-27T16:07:52Z

It's working in latest release 1.2.0

0xByteLeon · 2020-08-28T06:57:04Z

It's working in latest release 1.2.0

I still need set app:backgroundTint="@null" , else drawable background will not working

whilson03 · 2020-09-05T22:12:43Z

still not working

Library version: 1.2.0

smithaaron · 2020-09-08T14:15:10Z

This doesn't work for me on 1.2.1. This is what I've tried:

<com.google.android.material.floatingactionbutton.FloatingActionButton
            android:id="@+id/fab_filter"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_margin="@dimen/material_design_spacing_large"
            app:backgroundTint="@color/sort_fab_bg_selector"
            android:layout_gravity="end"
            app:maxImageSize="56dp"
            app:srcCompat="@drawable/ic_search_and_filter" />

<com.google.android.material.floatingactionbutton.FloatingActionButton
            android:id="@+id/fab_filter"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_margin="@dimen/material_design_spacing_large"
            app:backgroundTint="@null"
            android:background="@color/sort_fab_bg_selector"
            android:layout_gravity="end"
            app:maxImageSize="56dp"
            app:srcCompat="@drawable/ic_search_and_filter" />

Either way, the button is just black and the drawable isn't visible.

ymarian · 2020-09-08T14:34:59Z

@smithaaron this bug is for MaterialButton not for FloatingActionButton

CamiloVega · 2020-09-14T22:35:48Z

@ymarian I think they are related. I just updated to Material 1.2.1, and FAB was working like a charm, after the update it is not working properly

Veisy · 2020-10-05T21:25:06Z

This problem continues,
version 1.3.0-alpha03

ABHISHEK-AMRUTE · 2020-10-14T05:11:35Z

If you are concerned only about the android:background and not android:backgroundTint (as in my case), the following worked for me.
Set both android:background and android:backgroundTint programmatically
Here the android:backgroundTint is set to colour which I have used in my custom background.

        button1.setBackground(ContextCompat.getDrawable(getContext(),R.drawable.create_lobby_button));
        button2.setBackground(ContextCompat.getDrawable(getContext(),R.drawable.join_lobby_button));
        button1.setBackgroundTintList(this.getResources().getColorStateList(R.color.colorPrimaryDark));
        button2.setBackgroundTintList(this.getResources().getColorStateList(R.color.navigationbar_color));

IamAashis · 2020-12-18T07:39:23Z

solved with app:backgroundTint

Ya thanks it works

hemantlakhotia204 · 2021-02-01T13:34:22Z

Change Theme in styles from Theme.MaterialComponents.DayNight.DarkActionBar to Theme.MaterialComponents.DayNight.DarkActionBar.Bridge
It worked for me!

HenryMacharia254 · 2021-02-04T13:05:51Z

I changed from Button to com.google.android.material.button.MaterialButton and all was well in that the theme colors were applied.

BelalElhawary · 2021-03-13T15:38:45Z

fix it by change Theme.MaterialComponents.NoActionBar to Theme.MaterialComponents.NoActionBar.Bridge and it will work

KavinduDissanayake · 2021-03-13T17:44:09Z

just use for xml

app:backgroundTint="@color/purple_700"

that's it and it will be change the button color

No need to change the Theme it should be
"Theme.MaterialComponents.DayNight.NoActionBar" Or "Theme.MaterialComponents.DayNight.NoActionBar"

cholidridwan · 2021-03-20T22:55:41Z

Change Theme in styles from Theme.MaterialComponents.DayNight.DarkActionBar to Theme.MaterialComponents.DayNight.DarkActionBar.Bridge
It worked for me!

this also works for me, didn't need to add more xml / java code
Thanks

yash10019coder · 2021-06-04T16:28:18Z

still not works for me

this is code for my button
<Button android:id="@+id/button" android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="32dp" android:layout_marginLeft="32dp" android:layout_marginEnd="32dp" android:layout_marginRight="32dp" android:gravity="center|left" android:background="@drawable/background_button" android:text="SEND" app:layout_constraintBottom_toTopOf="@+id/button3" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@+id/editTextTextPersonName" />
this is the background code for my button

`
<shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle"

>
<solid android:color="#200540"

    />
<corners
    android:radius="100dp"
    />
<stroke android:color="@color/purple_500"
    android:width="10dp"
    />

`

Swavis · 2021-06-06T18:51:35Z

To work around this issue, do one of the following:

Add app:backgroundTint="@null" in xml or programmatically - btn.setBackgroundTintMode(null);
Change Theme Theme.MaterialComponents.DayNight.DarkActionBar to Theme.MaterialComponents.DayNight.DarkActionBar.Bridge

Both the solutions works fine.

Fs0ci3ty19 · 2021-06-19T21:53:13Z

To work around this issue, do one of the following:

Add app:backgroundTint="@null" in xml or programmatically - btn.setBackgroundTintMode(null);

Change Theme Theme.MaterialComponents.DayNight.DarkActionBar to Theme.MaterialComponents.DayNight.DarkActionBar.Bridge

Both the solutions works fine.

Theme.MaterialComponents.DayNight.DarkActionBar.Bridge
This one worked for me Thanks!!

ginagigo123 · 2021-07-23T09:29:14Z

Theme.MaterialComponents.DayNight.DarkActionBar
change to
Theme.AppCompat.DayNight.DarkActionBar works for me!

riverorange78 · 2022-07-01T03:59:03Z

c# ms vs 2022
Theme.MaterialComponents.Light.DarkActionBar
change to
Theme.MaterialComponents.Light.DarkActionBar.Bridge works for me!

Anshul-Jangra · 2022-07-28T01:18:13Z

In my app I used gradient on button, it runs but sometimes button is shown in normal button color. Can anyone tell me what is the problem?

Naught33 · 2022-07-28T05:47:31Z

Well the problem is that when I use drawables it looks okay on the xml design but once I install the app on my phone the color of the button goes back to default, althought the shape stays as I want it but the color ...

WangberlinT · 2022-10-11T10:04:03Z

still exist on 1.5.0

Anshul-Jangra · 2022-10-11T10:09:13Z

Thanks but it's resolved

0xByteLeon added the bug label Jan 9, 2020

wcshi closed this as completed Apr 1, 2020

nicoqueijo mentioned this issue Apr 12, 2020

Can't style keyboard properly while using Material Design 2 nicoqueijo/Android-Currency-Converter#9

Closed

nightlaro mentioned this issue Jul 29, 2021

Feature/choose button nightlaro/ColorTaste#1

Merged

[Button] android:background not working #889

[Button] android:background not working #889

Comments

0xByteLeon commented Jan 9, 2020

pekingme commented Jan 9, 2020

0xByteLeon commented Jan 10, 2020

0xByteLeon commented Jan 10, 2020

pekingme commented Jan 10, 2020

0xByteLeon commented Jan 14, 2020

hamed8080 commented Jan 25, 2020

ImAreeb commented Mar 8, 2020

diegoalvis commented Mar 26, 2020

0xByteLeon commented Apr 1, 2020

wcshi commented Apr 1, 2020

AlejandroHCruz commented Apr 8, 2020 • edited

pejman-74 commented Apr 11, 2020

AlejandroHCruz commented Apr 13, 2020

wcshi commented Apr 13, 2020

KidusMT commented Apr 17, 2020

AlejandroHCruz commented Apr 17, 2020

NehaDShakya commented Apr 20, 2020 • edited

nicoqueijo commented Apr 22, 2020 • edited

nickruddeni commented Apr 22, 2020

nicoqueijo commented Apr 22, 2020 • edited

AdislanSaidov commented Apr 24, 2020

AdislanSaidov commented Apr 24, 2020 • edited

dsn5ft commented Apr 29, 2020

Bhavnaharitsa commented May 11, 2020

0xByteLeon commented May 11, 2020

Bhavnaharitsa commented May 11, 2020

AlejandroHCruz commented May 11, 2020 via email

dsn5ft commented Jul 22, 2020

mecoFarid commented Aug 12, 2020

wcshi commented Aug 12, 2020

mecoFarid commented Aug 12, 2020

wcshi commented Aug 12, 2020

mecoFarid commented Aug 12, 2020

varunam commented Aug 27, 2020

0xByteLeon commented Aug 28, 2020

whilson03 commented Sep 5, 2020

smithaaron commented Sep 8, 2020 • edited

ymarian commented Sep 8, 2020

CamiloVega commented Sep 14, 2020

Veisy commented Oct 5, 2020

ABHISHEK-AMRUTE commented Oct 14, 2020

IamAashis commented Dec 18, 2020

hemantlakhotia204 commented Feb 1, 2021

HenryMacharia254 commented Feb 4, 2021

BelalElhawary commented Mar 13, 2021

KavinduDissanayake commented Mar 13, 2021

cholidridwan commented Mar 20, 2021

yash10019coder commented Jun 4, 2021

Swavis commented Jun 6, 2021 • edited

Fs0ci3ty19 commented Jun 19, 2021

ginagigo123 commented Jul 23, 2021

riverorange78 commented Jul 1, 2022

Anshul-Jangra commented Jul 28, 2022

Naught33 commented Jul 28, 2022

WangberlinT commented Oct 11, 2022

Anshul-Jangra commented Oct 11, 2022

AlejandroHCruz commented Apr 8, 2020 •

edited

NehaDShakya commented Apr 20, 2020 •

edited

nicoqueijo commented Apr 22, 2020 •

edited

nicoqueijo commented Apr 22, 2020 •

edited

AdislanSaidov commented Apr 24, 2020 •

edited

smithaaron commented Sep 8, 2020 •

edited

Swavis commented Jun 6, 2021 •

edited