Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict touchable area depends on translationX #20

Merged
merged 2 commits into from Jan 8, 2020
Merged

restrict touchable area depends on translationX #20

merged 2 commits into from Jan 8, 2020

Conversation

HeyAlex
Copy link
Contributor

@HeyAlex HeyAlex commented Jan 6, 2020

Fixes #19

hunterstich
hunterstich approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@hunterstich hunterstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex,

Thanks so much for contributing! This looks good to me.
I've added a small comment about documenting what LessonBottomSheetBehavior solves, but otherwise this looks great.

Owl/app/src/main/java/com/materialstudies/owl/ui/lessons/LessonBottomSheetBehavior.kt Show resolved Hide resolved
@matpag
Copy link

matpag commented Jan 8, 2020

I can confirm this works correctly. We did the same thing in our code to fix the problem

@hunterstich hunterstich merged commit 374b9c8 into material-components:develop Jan 8, 2020
This was referenced Jan 9, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterstich hunterstich hunterstich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem on LessonsSheetFragment, touchable area should be sized based on button size
3 participants
@HeyAlex @matpag @hunterstich