[ShapeableImageView] Support contentPadding

[drewhamilton]

Closes #1489. Adds contentPadding APIs to ShapeableImageView. This is achieved by communicating the sum of padding and contentPadding as a single value to the superclass (AppCompatImageView), but tracking them separately in this class. This maintains the existing behavior of ShapeableImageView padding, which pads the background, but takes advantage of the fact that AppCompatImageView does not pad the background.

Frankly the internal logic is a nightmare, and hard to wrap my head around even after writing it. But it's the only way I can get it to work while maintaining behavioral compatibility, and it seems to work as expected with some manual testing.

I'm happy to add tests but I can't figure out how they work in this project. Is there something special I need to do to get the IDE to recognize the test sources?

[jackthebeast]

so this was closed for what reason? any way to achieve this?

[drewhamilton]

@jackthebeast It was merged in c4f7de1! Via this repo's kinda-weird merge process. I wish someone had mentioned how to add tests first 😬 but I'll take it 😄

[jackthebeast]

@drewhamilton oh, that's weird, I was expecting a clear "merged" status... Anyway, I tried adding the latest alpha to gradle but couldn't find the new method. do you know when it'll become available?

[drewhamilton]

No, I don't know the release plans or cadence.

[jackthebeast]

thanks, I'll keep an eye on it

[jackthebeast]

@drewhamilton Hi, I saw it has been released. I was giving a try:
<com.google.android.material.imageview.ShapeableImageView android:layout_width="75dp" android:layout_height="75dp" android:background="@drawable/drawable_circle_check_quiz" app:contentPadding="15dp" app:shapeAppearanceOverlay="@style/CircleImageView" android:src="@drawable/ic_generic_user" />

<style name="CircleImageView" parent=""> <item name="cornerFamily">rounded</item> <item name="cornerSize">50%</item> </style>

which correctly adds padding to ic_generic_user. Now, however, ic_generic_user which is a squared vector drawable, is not cut to a circle anymore: example.

Any idea what's going on? did you manage to test such a case before?

[drewhamilton]

This is expected; the shape clips the view itself. Any content that does not intersect the edges of the shape of the view is unaffected.

The example you linked was not a consideration when I implemented contentPadding—personally my use case was transparent-background icons. Perhaps manipulating the bitmap itself would be the way to go. Or making the green part of your image a MaterialCardView (with contentPadding) and the grey part a ShapeableImageView (with no contentPadding`). Or of course you could file a new feature request for ShapeableImageView.

[jackthebeast]

This is expected; the shape clips the view itself. Any content that does not intersect the edges of the shape of the view is unaffected.

I see, I didn't know that.

The example you linked was not a consideration when I implemented contentPadding—personally my use case was transparent-background icons. Perhaps manipulating the bitmap itself would be the way to go. Or making the green part of your image a MaterialCardView (with contentPadding) and the grey part a ShapeableImageView (with no contentPadding`). Or of course you could file a new feature request for ShapeableImageView.

Yeah I was already doing something similar so no big deal, just want to simplify it. I will file a feature request and see if anyone else is interested.

[Aleksandramilova69]

4100115253233934