[CollapsingToolbarLayout] Allow application to Set ellipsis to Title in CollapsingToolBar #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to verify the middle ellipsize change in CollapsingToolBar
chaituapps2408
approved these changes
Apr 13, 2022
drchen
reviewed
Apr 13, 2022
lib/java/com/google/android/material/internal/CollapsingTextHelper.java
Outdated
Show resolved
Hide resolved
drchen
reviewed
Apr 14, 2022
lib/java/com/google/android/material/internal/CollapsingTextHelper.java
Outdated
Show resolved
Hide resolved
lib/java/com/google/android/material/internal/CollapsingTextHelper.java
Outdated
Show resolved
Hide resolved
drchen
reviewed
Apr 14, 2022
lib/java/com/google/android/material/appbar/CollapsingToolbarLayout.java
Outdated
Show resolved
Hide resolved
lib/java/com/google/android/material/appbar/CollapsingToolbarLayout.java
Outdated
Show resolved
Hide resolved
…o convert attr to TruncateAt
venugopalraog
changed the title
drchen
approved these changes
Apr 18, 2022
@drchen Thank you for update. Any update from internal review.. |
|
Hey, sorry for the delay. I need to add internal tests and doc updates. Hopefully will get this through this week or next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationcloses # 2631Contributing
has more information and tips for a great pull request.
Screenshots:
