Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color] Fix HarmonizedColorsOptions.Builder#setColorAttributes is marked as nullable #2649

Closed
wants to merge 1 commit into from
Closed

[Color] Fix HarmonizedColorsOptions.Builder#setColorAttributes is marked as nullable #2649

wants to merge 1 commit into from

Conversation

RikkaW
Copy link
Contributor

@RikkaW RikkaW commented Apr 18, 2022 •
edited

material-components-android/lib/java/com/google/android/material/color/HarmonizedColorsOptions.java

Lines 105 to 109 in 788866e

@Nullable
public Builder setColorAttributes(@Nullable HarmonizedColorAttributes colorAttributes) {
this.colorAttributes = colorAttributes;
return this;
}

Fix #2650

drchen
drchen approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@drchen drchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! : )

@drchen drchen added the Reviewing Internally An internal change has been created and sent for review. label Apr 18, 2022
@drchen drchen closed this in 824a12b Apr 19, 2022
dsn5ft pushed a commit that referenced this pull request Apr 19, 2022
@RikkaW @dsn5ft
[Color] Fix HarmonizedColorsOptions.Builder#setColorAttributes is mar…
44054aa 
…ked as nullable

Resolves #2649

GIT_ORIGIN_REV_ID=b1f2d2ca1d4c5b25370eb0902fbf35729d6fc0a4
PiperOrigin-RevId: 442676674

(cherry picked from commit 824a12b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drchen drchen drchen approved these changes

Assignees
No one assigned
Labels
Reviewing Internally An internal change has been created and sent for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Color] HarmonizedColorsOptions.Builder#setColorAttributes is marked as nullable
2 participants
@RikkaW @drchen