Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MaterialSwitch] Move public.xml to the correct directory #2759

Closed
wants to merge 1 commit into from
Closed

[MaterialSwitch] Move public.xml to the correct directory #2759

wants to merge 1 commit into from

Conversation

AshutoshSundresh
Copy link
Contributor

public.xml must be included within res-public/values and not res-public

This fixes the following error when compiling the Material components from source in the AOSP build system:

materialswitch/res-public/public.xml: error: invalid configuration 'public'.

drchen
drchen approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@drchen drchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops. Thanks for helping fix this!

@drchen drchen added the Reviewing Internally An internal change has been created and sent for review. label Jun 29, 2022
@drchen drchen closed this in aa59bdd Aug 4, 2022
drchen pushed a commit that referenced this pull request Aug 4, 2022
@AshutoshSundresh @drchen
[MaterialSwitch] Move public.xml to the correct directory
708b3b0 
Resolves #2759

GIT_ORIGIN_REV_ID=4e1baf0e5cc535c9e346e9a406063e47a9fe5b09
PiperOrigin-RevId: 464561173

(cherry picked from commit aa59bdd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drchen drchen drchen approved these changes

Assignees
No one assigned
Labels
Reviewing Internally An internal change has been created and sent for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AshutoshSundresh @drchen