Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Fix hardcoded number of children #2923

Conversation

anyercastillo
Copy link
Contributor

Fixes a bug that prevents developers to define an arbitrary number of maximum item in BottomNavigationView.

The problem.
BottomNavigationMenuView was using the static constant BottomNavigationView.MAX_ITEM_COUNT as part of its logic. So overriding BottomNavigationView.getMaxItemCount() with a value greater than BottomNavigationView.MAX_ITEM_COUNT causes the exception ArrayIndexOutOfBondsException

Related to #543

@google-cla
Copy link

google-cla bot commented Aug 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imhappi imhappi self-requested a review September 2, 2022 18:26
@imhappi
Copy link
Contributor

imhappi commented Sep 2, 2022

lgtm 👍

@imhappi imhappi added the Reviewing Internally An internal change has been created and sent for review. label Sep 2, 2022
@afohrman afohrman closed this in a2ce1dd Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Internally An internal change has been created and sent for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants