Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog] When bottom sheet is collapsed, back callback is enabled #3574

Closed
wants to merge 1 commit into from
Closed

[Catalog] When bottom sheet is collapsed, back callback is enabled #3574

wants to merge 1 commit into from

Conversation

manabu-nakamura
Copy link
Contributor

@dsn5ft
Copy link
Contributor

dsn5ft commented Sep 14, 2023

Thanks for these issues and PRs @manabu-nakamura.

I'm thinking of handling this a bit differently, by updating the state text and back callback enabled to be correct on rotation, instead of hiding/collapsing the bottom sheet on rotation. Will sync out the fix within the next few days.

@dsn5ft dsn5ft closed this in f9102c7 Sep 19, 2023
@manabu-nakamura manabu-nakamura deleted the bottomsheet branch September 20, 2023 00:00
afohrman pushed a commit that referenced this pull request Sep 21, 2023
@dsn5ft @afohrman
[Catalog][Predictive Back][Bottom Sheet] Update bottom sheet state ha…
386d47b 
…ndling to be more accurate in demos

Fixes inaccurate state label text and back callback enabled flag after rotation

Resolves #3573
Resolves #3575
Resolves #3577

Resolves #3574
Resolves #3576
Resolves #3578

PiperOrigin-RevId: 566286622
(cherry picked from commit f9102c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manabu-nakamura @dsn5ft