[Slider] Fix slider label not moving #3917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drchen
reviewed
Dec 12, 2023
| @@ -361,6 +361,8 @@ abstract class BaseSlider< | |||
| } | |||
| } | |||
| }; | |||
| @NonNull | |||
| private final ViewTreeObserver.OnGlobalLayoutListener onGlobalLayoutListener = onScrollChangedListener::onScrollChanged; | |||
There was a problem hiding this comment.
This is sort of confusing. Can we declare a method, say, updateLableVisibility(), and do something like:
private final ViewTreeObserver.OnScrollChangedListener onScrollChangedListener = this::updateLableVisibility;
private final ViewTreeObserver.OnGlobalLayoutListener onGlobalLayoutListener = this::updateLableVisibility;
instead?
There was a problem hiding this comment.
Thank you very much. I tried. I'm not sure if the name of the method is appropriate.
dsn5ft
reviewed
Dec 13, 2023
| }; | ||
| private final ViewTreeObserver.OnScrollChangedListener onScrollChangedListener = this::updateLabel; | ||
| @NonNull | ||
| private final ViewTreeObserver.OnGlobalLayoutListener onGlobalLayoutListener = this::updateLabel; |
There was a problem hiding this comment.
do we need both the global layout listener and the scroll listener or is just the global layout listener enough?
There was a problem hiding this comment.
By only the global layout listener, the slider label doesn't move while scrolling (#2869).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3124
#2869 (comment)