Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC-103 buttonColor breaking change #133

Closed
sattha opened this issue Nov 14, 2018 · 1 comment
Closed

MDC-103 buttonColor breaking change #133

sattha opened this issue Nov 14, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@sattha
Copy link

sattha commented Nov 14, 2018

According to this thread, the snippet in MDC-103 doesn't work for button color

// TODO: Build a Shrine Theme (103)
final ThemeData _kShrineTheme = _buildShrineTheme();

ThemeData _buildShrineTheme() {
  final ThemeData base = ThemeData.light();
  return base.copyWith(
    accentColor: kShrineBrown900,
    primaryColor: kShrinePink100,
    buttonColor: kShrinePink100,
    scaffoldBackgroundColor: kShrineBackgroundWhite,
    cardColor: kShrineBackgroundWhite,
    textSelectionColor: kShrinePink100,
    errorColor: kShrineErrorRed,
    // TODO: Add the text themes (103)
    // TODO: Add the icon themes (103)
    // TODO: Decorate the inputs (103)
  );
}

fix to this buttonTheme instead of buttonColor

// TODO: Build a Shrine Theme (103)
final ThemeData _kShrineTheme = _buildShrineTheme();

ThemeData _buildShrineTheme() {
  final ThemeData base = ThemeData.light();
  return base.copyWith(
    accentColor: kShrineBrown900,
    primaryColor: kShrinePink100,
    buttonTheme: base.buttonTheme.copyWith(buttonColor: kShrinePink100),
    scaffoldBackgroundColor: kShrineBackgroundWhite,
    cardColor: kShrineBackgroundWhite,
    textSelectionColor: kShrinePink100,
    errorColor: kShrineErrorRed,
    // TODO: Add the text themes (103)
    // TODO: Add the icon themes (103)
    // TODO: Decorate the inputs (103)
  );
}
jdkoren added a commit to jdkoren/material-components-flutter-codelabs that referenced this issue Dec 3, 2018
- Fix button color (github material-components#133)
- Restore obscureText on password field (github material-components#127)
- Change AccentColorOverride to PrimaryColorOverride (github material-components#128, material-components#132)
- Fix default BorderSide in CutCornersBorder constructor (github material-components#134)
jdkoren added a commit to jdkoren/material-components-flutter-codelabs that referenced this issue Dec 3, 2018
- Fix button color (github material-components#133)
- Restore obscureText on password field (github material-components#127)
- Change AccentColorOverride to PrimaryColorOverride (github material-components#128, material-components#132)
- Fix default BorderSide in CutCornersBorder constructor (github material-components#134)
jdkoren added a commit to jdkoren/material-components-flutter-codelabs that referenced this issue Dec 4, 2018
- Fix login button color (issue material-components#133)
- Restore obscureText on password field (issue material-components#127)
- Fix AccentColorOverride (issue material-components#128, material-components#132)
willlarche pushed a commit that referenced this issue Dec 4, 2018
* Fix default BorderSide in CutCornersBorder constructor

issue #134

* Miscellaneous fixes

- Fix login button color (issue #133)
- Restore obscureText on password field (issue #127)
- Fix AccentColorOverride (issue #128, #132)
@willlarche
Copy link
Collaborator

This should be corrected now both in document and sample code. Thank you!

@willlarche willlarche added bug Something isn't working Document labels Dec 26, 2018
willlarche added a commit that referenced this issue Mar 25, 2019
[101] Making AppBar something you add in 102.

[Model] Adding model from the start.

[103] Adding fonts.

[103] Supplemental files.

[101] Correcting supplemental files.

[101] Copy correction.

[101] Minor renaming.

[101] Update for Dart 2.

[101] Missing dependency.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Correcting model.

[Meta] README file.

[Meta] Clarification.

[101] Copy correction.

[104] Updating data.

[101] Correcting widget class. (#23)

Add link to actual codelab in the README

[Meta] README correction.

[101] README specificity.

Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44)

[101] TODOs for starter code (#50)

[101] Added future TODOs to 101 starter

[101] Included lines to ignore .iml files and files in idea/ (#67)

[101] Remove 104 comments

[All] Icons for Android and iOS. (#69)

[101] Add .vscode/ to gitignore, stop tracking ignored files (#71)

Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment.

[101] Removed legacy 'new' and 'const' from 101 starter codelab (#72)

[101] Restore legacy to data.dart and product.dart (#75)

[101] Update import for app.dart to stop type errors in future codelabs (#83)

Replace data.dart (#99)

[All] Adding back in filter functionality. (#112)

[106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115)

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

[101] Completed code.

[102] Completed code.

[103] Completed code.

104 starter (#136)

* Fix default BorderSide in CutCornersBorder constructor

issue #134

* Miscellaneous fixes

- Fix login button color (issue #133)
- Restore obscureText on password field (issue #127)
- Fix AccentColorOverride (issue #128, #132)

[103] Button theme fix.

[104] Updating pubspec

[103] Completed code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants