Changed android gradle files to make Android X compatible #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myraeisme
approved these changes
Jan 3, 2020
rami-a
approved these changes
Jan 6, 2020
|
Thanks @sudiptachatterjee for making this change! |
guidezpl
pushed a commit
that referenced
this pull request
Apr 23, 2022
[101] Starter code. Changed android gradle files to make Android X compatible (#172) Add todo for slanted menu asset in 101 (#179) Updated TextStyles in product_card.dart (#186) Updated with new TextStyles. Add environment constraint Add environment constraint correctly Migrate 101-starter to NNBD (#222) (#231) * Update version. * Migrate. Co-authored-by: Tianguang <penn.zht@gmail.com> Updates for latest flutter stable (#240) * Recreate android and ios Update to Android embedding v2 Deletes png assets by using Android's adaptive launcher icon system Recreates ios/ Bumps up pubspec versions * Gradle bump update ios icon and name (#244) Adopting flutter_lints for 101-starter branch (#251) remove unnecessary import fix formatting fix Android build issues Delete widget_test.dart remove outdated TODOs Update login.dart fix product_card text styles declare routes, rather than using onGenerateRoute and home incorrectly
guidezpl
pushed a commit
that referenced
this pull request
Apr 23, 2022
Changed android gradle files to make Android X compatible (#172) Add todo for slanted menu asset in 101 (#179) Updated TextStyles in product_card.dart (#186) Updated with new TextStyles. Add environment constraint Add environment constraint correctly Migrate 101-starter to NNBD (#222) (#231) * Update version. * Migrate. Co-authored-by: Tianguang <penn.zht@gmail.com> Updates for latest flutter stable (#240) * Recreate android and ios Update to Android embedding v2 Deletes png assets by using Android's adaptive launcher icon system Recreates ios/ Bumps up pubspec versions * Gradle bump update ios icon and name (#244) Adopting flutter_lints for 101-starter branch (#251) remove unnecessary import fix formatting fix Android build issues Delete widget_test.dart remove outdated TODOs Update login.dart fix product_card text styles declare routes, rather than using onGenerateRoute and home incorrectly
guidezpl
pushed a commit
that referenced
this pull request
Apr 23, 2022
Changed android gradle files to make Android X compatible (#172) Add todo for slanted menu asset in 101 (#179) Updated TextStyles in product_card.dart (#186) Updated with new TextStyles. Add environment constraint Add environment constraint correctly Migrate 101-starter to NNBD (#222) (#231) * Update version. * Migrate. Co-authored-by: Tianguang <penn.zht@gmail.com> Updates for latest flutter stable (#240) * Recreate android and ios Update to Android embedding v2 Deletes png assets by using Android's adaptive launcher icon system Recreates ios/ Bumps up pubspec versions * Gradle bump update ios icon and name (#244) Adopting flutter_lints for 101-starter branch (#251) remove unnecessary import fix formatting fix Android build issues Delete widget_test.dart remove outdated TODOs Update login.dart fix product_card text styles declare routes, rather than using onGenerateRoute and home incorrectly
guidezpl
pushed a commit
that referenced
this pull request
Apr 19, 2023
Changed android gradle files to make Android X compatible (#172) Add todo for slanted menu asset in 101 (#179) Updated TextStyles in product_card.dart (#186) Updated with new TextStyles. Add environment constraint Add environment constraint correctly Migrate 101-starter to NNBD (#222) (#231) * Update version. * Migrate. Co-authored-by: Tianguang <penn.zht@gmail.com> Updates for latest flutter stable (#240) * Recreate android and ios Update to Android embedding v2 Deletes png assets by using Android's adaptive launcher icon system Recreates ios/ Bumps up pubspec versions * Gradle bump update ios icon and name (#244) Adopting flutter_lints for 101-starter branch (#251) remove unnecessary import fix formatting fix Android build issues Delete widget_test.dart remove outdated TODOs Update login.dart fix product_card text styles declare routes, rather than using onGenerateRoute and home incorrectly Update to M3 - Start (#284) * Update to M3 * Adding desktop targets * Update app.dart * Update app.dart * Update app.dart fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers are running into a lot of problems when they start with the MDC codelab due to Android X issues. I ran into the same ones and figured out that changing these files will make the codelab work perfectly.
Once you accept this, I'll submit PRs for the rest of the steps in the codelab.