Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shrine theme to have correct color on login buttons #177

Merged
merged 2 commits into from Feb 19, 2020
Merged

Update shrine theme to have correct color on login buttons #177

merged 2 commits into from Feb 19, 2020

Conversation

perclasson
Copy link
Contributor

@perclasson perclasson commented Feb 12, 2020 •
edited

This will be merged in together with changes to the codelab.

Before:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-12 at 12 13 12

After:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-12 at 12 28 52

Closes #171

@perclasson perclasson force-pushed the 104-starter_and_103-complete_color_fix branch from efb40b3 to 0f0decc Compare February 12, 2020 11:28
@perclasson perclasson changed the title Update shrine theme to have correct color on cancel button Update shrine theme to have correct color on login buttons Feb 12, 2020
guidezpl
guidezpl approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

@perclasson perclasson force-pushed the 104-starter_and_103-complete_color_fix branch from 0f0decc to 2588ae8 Compare February 12, 2020 11:35
@perclasson perclasson force-pushed the 104-starter_and_103-complete_color_fix branch from 2588ae8 to 9d4cc35 Compare February 12, 2020 11:46
rami-a
rami-a approved these changes Feb 12, 2020
View reviewed changes
Copy link

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you also have to modify the other codelab branches too?

@perclasson perclasson mentioned this pull request Feb 12, 2020
Merged
@perclasson
Copy link
Contributor Author

LGTM, but do you also have to modify the other codelab branches too?

True:
#178

@perclasson perclasson merged commit c30c2a7 into material-components:104-starter_and_103-complete Feb 19, 2020
@perclasson perclasson deleted the 104-starter_and_103-complete_color_fix branch February 19, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami-a rami-a rami-a approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perclasson @rami-a @guidezpl