Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update textstyles on home.dart #189

Conversation

adoankim
Copy link

@adoankim adoankim commented May 30, 2020

Updating textstyles on home.dart by replacing deprecated textThemes with the new ones :)

Edit: I guess the codelab textstyle related instructions should be updated too? 馃 . However haven't found where they are.

TextTheme _buildShrineTextTheme(TextTheme base) {
  return base.copyWith(
    headline: base.headline.copyWith(
      fontWeight: FontWeight.w500,
    ),
    title: base.title.copyWith(
        fontSize: 18.0
    ),
    caption: base.caption.copyWith(
      fontWeight: FontWeight.w400,
      fontSize: 14.0,
    ),
  ).apply(
    fontFamily: 'Rubik',
    displayColor: kShrineBrown900,
    bodyColor: kShrineBrown900,
  );
}

To

TextTheme _buildShrineTextTheme(TextTheme base) {
  return base
      .copyWith(
        headline5: base.headline5.copyWith(
          fontWeight: FontWeight.w500,
        ),
        headline6: base.headline6.copyWith(fontSize: 18.0),
        caption: base.caption.copyWith(
          fontWeight: FontWeight.w400,
          fontSize: 14.0,
        ),
      )
      .apply(
        fontFamily: 'Rubik',
        displayColor: kShrineBrown900,
        bodyColor: kShrineBrown900,
      );
}

Replaces deprecated textThemes by the new ones
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@adoankim
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@clocksmith clocksmith mentioned this pull request Jun 18, 2020
@clocksmith clocksmith merged commit e61e5f2 into material-components:103-starter_and_102-complete Jun 23, 2020
guidezpl pushed a commit that referenced this pull request Apr 23, 2022
Update textstyles on home.dart (#189)

Replaces deprecated textThemes by the new ones

Updated TextStyles in product_card.dart (#186) (#194)

Updated with new TextStyles.

Co-authored-by: Rex B Ferrer <ferrergordonrb@g.cofc.edu>

Add environment constraint

Migrate 102-complete to NNBD (#220) (#233)

* Migrate.

* Update SDK version.

* Update version for intl.

Co-authored-by: Tianguang <penn.zht@gmail.com>

Migrate deprecated buttons in 103-starter (#237)

Updates for latest flutter stable (#240)

* Recreate android and ios

Update to Android embedding v2
Deletes png assets by using Android's adaptive launcher icon system
Recreates ios/
Bumps up pubspec versions

* Gradle bump

tweak AppBar

tweak AppBar

undo tweaks

update ios icon and name

Adopting flutter_lints on 103-starter (#253)

remove unnecessary import

fix formatting

update iOS build

fix Android build issues

Delete widget_test.dart

replace ButtonBar with OverflowBar

remove outdated TODOs

Update login.dart

fix product_card text styles

declare routes, rather than using onGenerateRoute and home incorrectly
guidezpl pushed a commit that referenced this pull request Apr 23, 2022
Update textstyles on home.dart (#189)

Replaces deprecated textThemes by the new ones

Updated TextStyles in product_card.dart (#186) (#194)

Updated with new TextStyles.

Co-authored-by: Rex B Ferrer <ferrergordonrb@g.cofc.edu>

Add environment constraint

Migrate 102-complete to NNBD (#220) (#233)

* Migrate.

* Update SDK version.

* Update version for intl.

Co-authored-by: Tianguang <penn.zht@gmail.com>

Migrate deprecated buttons in 103-starter (#237)

Updates for latest flutter stable (#240)

* Recreate android and ios

Update to Android embedding v2
Deletes png assets by using Android's adaptive launcher icon system
Recreates ios/
Bumps up pubspec versions

* Gradle bump

tweak AppBar

tweak AppBar

undo tweaks

update ios icon and name

Adopting flutter_lints on 103-starter (#253)

remove unnecessary import

fix formatting

update iOS build

fix Android build issues

Delete widget_test.dart

replace ButtonBar with OverflowBar

remove outdated TODOs

Update login.dart

fix product_card text styles

declare routes, rather than using onGenerateRoute and home incorrectly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants