Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom AccentOverride widget solution with theme styling solution #198

Merged
merged 3 commits into from Jun 29, 2020
Merged

Replace custom AccentOverride widget solution with theme styling solution #198

merged 3 commits into from Jun 29, 2020

Conversation

Renzo-Olivares
Copy link

Fixes #196

  • Depends on updating mdc 103 codelab instructions
  • Uses styling instead of custom AccentOverride widget to decorate the input text field for username and password.

@Renzo-Olivares
Remove AccentOverride widget instead update styling for _kShrineTheme
8d8b201 
* Add focusedBorder styling for inputDecorationTheme
* Make InputDecoration labelstyle dynamic for focus/unfocused using FocusNode
@Renzo-Olivares Renzo-Olivares merged commit c38c64c into material-components:104-starter_and_103-complete Jun 29, 2020
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clocksmith clocksmith clocksmith approved these changes

@rami-a rami-a rami-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Renzo-Olivares @clocksmith @rami-a