Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Finish Remaining Details of Shrine #141

Closed
3 of 7 tasks
pennzht opened this issue Nov 8, 2019 · 0 comments
Closed
3 of 7 tasks

Finish Remaining Details of Shrine #141

pennzht opened this issue Nov 8, 2019 · 0 comments
Assignees
@pennzht
Labels
migrated Moved to flutter/gallery P3 Priority 3 - Could have study Building/fixing/updating a Material case study
Projects
Backlog

Comments

@pennzht
Copy link
Contributor

pennzht commented Nov 8, 2019 •
edited

Acceptance Criteria

Finish the following parts for the Shrine desktop layout:

  • 11-25 Desktop login screen (Shrine: Desktop login screen #356)
  • Some minor details
    • 12-17 Use correct letter spacing for certain labels (Gallery — Shrine: Update Letter Spacing flutter/samples#187)
    • Use correct vertical gaps between cards
      • Make sure vertical gaps between product cards on the product page have dimensions that match the specs file.
    • Use correct animation specs
      • Make sure all animations match specs file.
  • Scrollable vertical sidebar of categories (issue only visible when too many categories)
    • When the vertical sidebar contains too many categories (consider 10–20), it overflows instead of becomes scrollable.
    • Make it scrollable so that all categories can be accessed.
  • 11-21 Implement RTL support (Implement RTL support for Shrine #297)

Related Issues
@rami-a rami-a added this to Icebox in Backlog via automation Nov 11, 2019
@rami-a rami-a added the P3 Priority 3 - Could have label Nov 11, 2019
@pennzht pennzht mentioned this issue Nov 20, 2019
Closed
@pennzht pennzht self-assigned this Nov 21, 2019
@pennzht pennzht mentioned this issue Nov 22, 2019
Merged
@pennzht pennzht mentioned this issue Dec 13, 2019
Merged
@rami-a rami-a added the study Building/fixing/updating a Material case study label Feb 3, 2020
@pennzht pennzht mentioned this issue Mar 30, 2020
Closed
7 tasks
@pennzht pennzht added the migrated Moved to flutter/gallery label Mar 30, 2020
@rami-a rami-a closed this as completed Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pennzht pennzht

Labels
migrated Moved to flutter/gallery P3 Priority 3 - Could have study Building/fixing/updating a Material case study
Projects
Backlog
  
Icebox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rami-a @pennzht