Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Shrine: Desktop login screen #356

Merged
merged 15 commits into from Nov 25, 2019
Merged

Shrine: Desktop login screen #356

merged 15 commits into from Nov 25, 2019

Conversation

pennzht
Copy link
Contributor

@pennzht pennzht commented Nov 22, 2019

Description

Add desktop login screen for shrine.

Related Issues

An item in #141 — Finish Remaining Details of Shrine

image

perclasson
perclasson approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one nit that is debatable. :)

gallery/lib/studies/shrine/login.dart Outdated Show resolved Hide resolved
@pennzht
Copy link
Contributor Author

pennzht commented Nov 25, 2019

Blocked by: Replace deprecated methods #357.

@pennzht pennzht requested a review from rami-a November 25, 2019 13:45
@pennzht
Copy link
Contributor Author

pennzht commented Nov 25, 2019

Unblocked.

johnsonmh
johnsonmh approved these changes Nov 25, 2019
View reviewed changes
Copy link

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

gallery/lib/studies/shrine/login.dart Outdated Show resolved Hide resolved
gallery/lib/studies/shrine/login.dart Outdated Show resolved Hide resolved
gallery/lib/studies/shrine/login.dart Outdated Show resolved Hide resolved
@pennzht pennzht merged commit 560c9f6 into master Nov 25, 2019
@pennzht pennzht deleted the shrine_desktop_login branch November 25, 2019 17:04
@pennzht pennzht mentioned this pull request Nov 25, 2019
Closed
7 tasks
@pennzht pennzht mentioned this pull request Mar 30, 2020
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perclasson perclasson perclasson approved these changes

@johnsonmh johnsonmh johnsonmh approved these changes

@JoseAlba JoseAlba JoseAlba approved these changes

@rami-a rami-a Awaiting requested review from rami-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pennzht @perclasson @johnsonmh @JoseAlba