This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Collapse other open sections when tap on setting #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseAlba
reviewed
Nov 29, 2019
| @@ -181,7 +177,8 @@ class _SettingsListItemState<T> extends State<SettingsListItem<T>> | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| final bool closed = !_isExpanded && _controller.isDismissed; | |||
| _handleExpansion(); | |||
| final bool closed = !widget.isExpanded && _controller.isDismissed; | |||
There was a problem hiding this comment.
closed variable made but never used in PR
There was a problem hiding this comment.
It's still used in line 207
rami-a
approved these changes
Nov 29, 2019
gallery/lib/pages/settings.dart
Outdated
| @@ -95,6 +114,8 @@ class SettingsPage extends StatelessWidget { | |||
| context, | |||
| options.copyWith(customTextDirection: newTextDirection), | |||
| ), | |||
| onTapSetting: () => onTapSetting(1), | |||
There was a problem hiding this comment.
Since you repeat each id twice, probably best to make consts to avoid errors
| @@ -181,7 +177,8 @@ class _SettingsListItemState<T> extends State<SettingsListItem<T>> | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| final bool closed = !_isExpanded && _controller.isDismissed; | |||
| _handleExpansion(); | |||
| final bool closed = !widget.isExpanded && _controller.isDismissed; | |||
JoseAlba
approved these changes
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so at most one setting subsection is open at a time.
It also uses ListView.builder instead of Column to display options, but doesn't fix the choppiness issue
Related Issues
Closes #347
#346