New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on stable flutter instead of master #30
Depend on stable flutter instead of master #30
Conversation
…th a desired transition
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change fixes #29
Navigator 2.0 has been merged into the stable branch of Flutter and landed with version 1.22 this month, but the
TransitionBuilderPage
(used to build pages with custom transitions) has not landed on stable. Issue #29 points out that the build is broken. To reduce build breakages we should depend on stable. This change includes any overhead for thestarter
branch to depend on stable.This change implements a
CustomTransitionBuilderPage
, as a temporary solution forTransitionBuilderPage
not being on stable.Code snippets in instructions should be updated to reflect new code. Instructions to be on master branch at the beginning of the codelab can also be removed/replaced with stable branch.