feat: Add Chips page #103
Merged
feat: Add Chips page #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnmercier
suggested changes
May 3, 2018
src/ChipsCatalog.js
Outdated
| this.chipSet = new MDCChipSet(chipSetEl); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: you can pull this all out of the constructor and just do this
initChipSet = (chipSetEl) => chipSetEl && this.chipSet = new MDCChipSet(chipSetEl);
There was a problem hiding this comment.
Done, except I think React doesn't like assignments next to a logical operator.
src/ChipsCatalog.js
Outdated
| <div> | ||
| <h3>Choice Chips</h3> | ||
| <div className='mdc-chip-set mdc-chip-set--choice' ref={this.initChipSet}> | ||
| {this.renderChip('Extra Small')} |
There was a problem hiding this comment.
something weird is happening with the ripple on choice chips...not sure if that is catalog's fault or the mdc-chip's fault
There was a problem hiding this comment.
Seems to be the 1-pixel gap issue that's also happening in button. Fixed in Chrome v67.
lynnmercier
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display filter, choice, and action chips. Fixes #25.
Input chips are still WIP and the API may change significantly.