Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document tab bar & tab #586

Closed
e111077 opened this issue Oct 24, 2019 · 0 comments · Fixed by #871 or #872
Closed

Document tab bar & tab #586

e111077 opened this issue Oct 24, 2019 · 0 comments · Fixed by #871 or #872
Assignees
@e111077

Comments

@e111077
Copy link
Member

e111077 commented Oct 24, 2019

No description provided.

@e111077 e111077 assigned e111077 and unassigned dfreedm Jan 9, 2020
@e111077 e111077 mentioned this issue Feb 17, 2020
Merged
copybara-service bot pushed a commit that referenced this issue Feb 17, 2020
@copybara-github
Document tabs & add icon slot name
264a780 
fixes #586

Documented tab and tab-bar as well as change the default `slot` to be `slot[name="icon"]`

Reasoning: it would break the following use case:

```html
<mwc-tab
  icon="camera">
</mwc-tab>
```

as the empty text node would override the default slot's contents.

Will require internal migration.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#871 from material-components:document-tabs af67f56
PiperOrigin-RevId: 295565678
@copybara-service copybara-service bot mentioned this issue Feb 17, 2020
Merged
copybara-service bot pushed a commit that referenced this issue Feb 18, 2020
@copybara-github
Document tabs & add icon slot name
d2c4c2b 
fixes #586

Documented tab and tab-bar as well as change the default `slot` to be `slot[name="icon"]`

Reasoning: it would break the following use case:

```html
<mwc-tab
  icon="camera">
</mwc-tab>
```

as the empty text node would override the default slot's contents.

Will require internal migration.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#871 from material-components:document-tabs af67f56
PiperOrigin-RevId: 295565678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e111077 e111077

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dfreedm @e111077