fix: updated function name and tests

material-components · Jun 15, 2018 · 7c2794d · 7c2794d
1 parent bf7f849
commit 7c2794d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/packages/text-field/Input.js b/packages/text-field/Input.js
@@ -79,12 +79,15 @@ export default class Input extends React.Component {
 
   handleValidationAttributeUpdate = (nextProps) => {
     const {foundation} = nextProps;
-
-    VALIDATION_ATTR_WHITELIST.some((attr) => {
+    VALIDATION_ATTR_WHITELIST.some((attributeName) => {
+      let attr = attributeName;
+      if (attributeName === 'minlength') {
+        attr = 'minLength';
+      } else if (attributeName === 'maxlength') {
+        attr = 'maxLength';
+      }
       if (this.props[attr] !== nextProps[attr]) {
-        foundation.handleValidationAttributeMutation([{
-          attributeName: attr,
-        }]);
+        foundation.handleValidationAttributeChange([attributeName]);
         return true;
       }
     });

diff --git a/test/unit/text-field/Input.test.js b/test/unit/text-field/Input.test.js
@@ -56,11 +56,6 @@ test('#componentDidMount does not throw errow if props.id is passed', () => {
   shallow(<Input id='123-best-id' />);
 });
 
-test('#componentDidMount does not throw errow if validation attr is updated', () => {
-  const wrapper = shallow(<Input />);
-  wrapper.setProps({required: true});
-});
-
 test('#componentDidMount should not call any method if disabled and id do not exist', () => {
   const setDisabled = td.func();
   const setInputId = td.func();
@@ -73,14 +68,19 @@ test('#componentDidMount should not call any method if disabled and id do not ex
   td.verify(setDisabled(td.matchers.isA(Boolean)), {times: 0});
 });
 
-test('#componentWillReceiveProps calls handleValidationAttributeMutation_ when ' +
+test('change to minLength calls handleValidationAttributeChange', () => {
+  const handleValidationAttributeChange = td.func();
+  const wrapper = shallow(<Input foundation={{handleValidationAttributeChange}} />);
+  wrapper.setProps({minLength: 20});
+  td.verify(handleValidationAttributeChange(['minlength']), {times: 1});
+});
+
+test('#componentWillReceiveProps calls handleValidationAttributeChange when ' +
   'a whitelisted attr updates', () => {
-  const foundation = {handleValidationAttributeMutation_: td.func()};
-  const wrapper = shallow(<Input foundation={foundation} />);
+  const handleValidationAttributeChange = td.func();
+  const wrapper = shallow(<Input foundation={{handleValidationAttributeChange}} />);
   wrapper.setProps({required: true});
-  td.verify(foundation.handleValidationAttributeMutation_([{
-    attributeName: 'pattern',
-  }]), {times: 1});
+  td.verify(handleValidationAttributeChange(['required']), {times: 1});
 });
 
 test('#componentWillReceiveProps calls setDisabled and foundation.setDisabled when ' +