Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infrastructure): default npm entry point to ES5 #108

Merged
merged 4 commits into from Jun 21, 2018

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jun 20, 2018

fixes #107 #100

@codecov-io
Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          18       18           
  Lines         637      637           
  Branches       53       53           
=======================================
  Hits          631      631           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5341c...0c30d85. Read the comment docs.

@@ -3,6 +3,7 @@
"version": "0.2.0",
"description": "Material Components React Button",
"license": "Apache-2.0",
"main": "dist/index.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better as another pr: if you still want an esm build like Dan mentioned, you could run Babel with ["env", { "modules": false" }] into a new dist type folder and add the module field like with main so it just doesn't touch the import/exports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzoo I just pushed some changes that doesn't touch the import/exports by adding the {modules: false} options. I think its working correctly as I'm now seeing lines like this:

/* harmony import */ var __WEBPACK_IMPORTED_MODULE_0_react__ = __webpack_require__(0);```

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moog16
Copy link
Contributor Author

moog16 commented Jun 21, 2018

Discussed offline: renamed <package_name>.map.js --> index.map.js and created .es.js files as part of dist directory.

@moog16 moog16 merged commit 1f0446f into master Jun 21, 2018
@moog16 moog16 deleted the feat/no-experimental-syntax branch June 21, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants